Add owners files for the nodejs code #1119

roberthbailey · 2019-10-16T03:42:42Z

Two reasons:

To document that @steven-supersolid is handling the bulk of the code reviews (especially for style).
This will cause the blunderbuss plugin for prow to auto assign code reviews.

google-oss-robot · 2019-10-16T03:42:43Z

@roberthbailey: GitHub didn't allow me to assign the following users: steven-supersolid.

Note that only googleforgames members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Two reasons:

To document that @steven-supersolid is handling the bulk of the code reviews (especially for style).

This will cause the blunderbuss plugin for prow to auto assign code reviews.

/assign @steven-supersolid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

agones-bot · 2019-10-16T04:13:02Z

Build Succeeded 👏

Build Id: 4825820e-8be8-4024-b8a8-e3ffd7666832

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-1778607
image: gcr.io/agones-images/agones-sdk:1.1.0-1778607
image: gcr.io/agones-images/agones-ping:1.1.0-1778607
Linux C++ SDK (build): agonessdk-1.1.0-1778607-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-1778607.zip

A preview of the website (the last 30 builds are retained):

https://1778607-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-1778607

google-oss-robot · 2019-10-16T04:25:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2019-10-16T04:25:26Z

New changes are detected. LGTM label has been removed.

agones-bot · 2019-10-16T04:55:32Z

Build Succeeded 👏

Build Id: 947b9601-40dd-4860-815b-4e05943fac40

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-d360a1d
image: gcr.io/agones-images/agones-sdk:1.1.0-d360a1d
image: gcr.io/agones-images/agones-ping:1.1.0-d360a1d
Linux C++ SDK (build): agonessdk-1.1.0-d360a1d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-d360a1d.zip

A preview of the website (the last 30 builds are retained):

https://d360a1d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-d360a1d

agones-bot · 2019-10-16T07:05:55Z

Build Succeeded 👏

Build Id: 38a35aee-79ef-4470-9796-61a86da0c1a1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-2b7bb65
image: gcr.io/agones-images/agones-sdk:1.1.0-2b7bb65
image: gcr.io/agones-images/agones-ping:1.1.0-2b7bb65
Linux C++ SDK (build): agonessdk-1.1.0-2b7bb65-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-2b7bb65.zip

A preview of the website (the last 30 builds are retained):

https://2b7bb65-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-2b7bb65

agones-bot · 2019-10-16T07:48:31Z

Build Succeeded 👏

Build Id: f1051615-72a6-407f-b927-55b2585374ed

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-d34670f
image: gcr.io/agones-images/agones-sdk:1.1.0-d34670f
image: gcr.io/agones-images/agones-ping:1.1.0-d34670f
Linux C++ SDK (build): agonessdk-1.1.0-d34670f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-d34670f.zip

A preview of the website (the last 30 builds are retained):

https://d34670f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-d34670f

pooneh-m · 2019-10-16T16:19:49Z

@roberthbailey Prow has tagged this as do-not-merge/invalid-owners-file. It seems that for some reason Prow cannot verify the owner.

roberthbailey · 2019-10-16T17:35:17Z

I created #1120 and assigned it to @thisisnotapril to figure out how we want to manage collaborators in this repo (and the org).

roberthbailey · 2019-10-20T06:30:48Z

/hold

Waiting on #1120

markmandel · 2019-10-25T18:30:16Z

Is this still on hold?

Meta question - @steven-supersolid have you met the criteria to become a full approver?

roberthbailey · 2019-10-25T18:34:20Z

/hold cancel

@steven-supersolid is now a repo collaborator so regardless of approver status this should be ok to go in now.

roberthbailey · 2019-10-25T18:34:36Z

/verify-owners

roberthbailey · 2019-10-25T18:35:25Z

/assign @steven-supersolid

roberthbailey · 2019-10-25T18:35:41Z

boom! assignment totally works now. :)

agones-bot · 2019-10-25T18:49:38Z

Build Succeeded 👏

Build Id: 97fa8760-8059-433d-8f23-58a4e29b4234

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-3363f7a
image: gcr.io/agones-images/agones-sdk:1.1.0-3363f7a
image: gcr.io/agones-images/agones-ping:1.1.0-3363f7a
Linux C++ SDK (build): agonessdk-1.1.0-3363f7a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-3363f7a.zip

A preview of the website (the last 30 builds are retained):

https://3363f7a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-3363f7a

steven-supersolid · 2019-10-26T21:42:53Z

Thanks for adding me! I think I meet the requirements for approver too if that is ever required but happy to just review for now

is handling the bulk of the code reviews (especially for style).

agones-bot · 2019-10-28T07:58:14Z

Build Failed 😱

Build Id: dfa49c88-8b82-4071-8928-b5d475223e18

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2019-10-28T18:26:52Z

Build error:

includes/sdk.mk:102: recipe for target 'build-build-sdk-image' failed
The command '/bin/sh -c go get github.com/golang/protobuf/[email protected] &&     go get -u golang.org/x/tools/cmd/goimports' returned a non-zero code: 1
make[4]: *** [build-build-sdk-image] Error 1
make[4]: Leaving directory '/workspace/build'
make[3]: *** [ensure-image] Error 2
includes/build-image.mk:53: recipe for target 'ensure-image' failed
includes/sdk.mk:119: recipe for target 'ensure-build-sdk-image' failed
make[2]: *** [ensure-build-sdk-image] Error 2
Unable to find image 'agones-build-sdk-go:4861e7b00a' locally
docker: Error response from daemon: pull access denied for agones-build-sdk-go, repository does not exist or may require 'docker login'.
See 'docker run --help'.
includes/sdk.mk:84: recipe for target 'run-sdk-command' failed
make[1]: *** [run-sdk-command] Error 125
includes/sdk.mk:76: recipe for target 'run-sdk-command-go' failed
make: *** [run-sdk-command-go] Error 2

Retrying to see if this was transient or is repeatable.

agones-bot · 2019-10-28T18:39:57Z

Build Succeeded 👏

Build Id: ad567c4f-4e4e-4731-a66c-8900b945f428

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-d339619
image: gcr.io/agones-images/agones-sdk:1.1.0-d339619
image: gcr.io/agones-images/agones-ping:1.1.0-d339619
Linux C++ SDK (build): agonessdk-1.1.0-d339619-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-d339619.zip

A preview of the website (the last 30 builds are retained):

https://d339619-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-d339619

agones-bot · 2019-10-28T19:18:14Z

Build Failed 😱

Build Id: 79352a37-1d23-46fc-9988-a1ed95ff725a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-10-28T20:52:31Z

Build Failed 😱

Build Id: 2fc4886a-a017-4535-9a30-b6d5ae887d8e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-10-28T21:10:05Z

Build Succeeded 👏

Build Id: de2addcc-f531-4795-bfa4-4795da20a27d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-2447fe9
image: gcr.io/agones-images/agones-sdk:1.1.0-2447fe9
image: gcr.io/agones-images/agones-ping:1.1.0-2447fe9
Linux C++ SDK (build): agonessdk-1.1.0-2447fe9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-2447fe9.zip

A preview of the website (the last 30 builds are retained):

https://2447fe9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1119/head:pr_1119 && git checkout pr_1119
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-2447fe9

google-oss-robot requested review from EricFortin and ilkercelikyilmaz October 16, 2019 03:42

google-oss-robot added approved size/XS do-not-merge/invalid-owners-file labels Oct 16, 2019

pooneh-m approved these changes Oct 16, 2019

View reviewed changes

google-oss-robot assigned pooneh-m Oct 16, 2019

google-oss-robot added the lgtm label Oct 16, 2019

google-oss-robot removed the lgtm label Oct 16, 2019

roberthbailey force-pushed the nodejs-owners branch from d360a1d to 2b7bb65 Compare October 16, 2019 06:36

roberthbailey force-pushed the nodejs-owners branch from 2b7bb65 to d34670f Compare October 16, 2019 07:16

roberthbailey mentioned this pull request Oct 16, 2019

Allow issues to be assigned to collaborators #1120

Closed

google-oss-robot added the do-not-merge/hold label Oct 20, 2019

google-oss-robot removed the do-not-merge/hold label Oct 25, 2019

google-oss-robot removed the do-not-merge/invalid-owners-file label Oct 25, 2019

roberthbailey force-pushed the nodejs-owners branch from d34670f to 3363f7a Compare October 25, 2019 18:35

google-oss-robot assigned steven-supersolid Oct 25, 2019

Add owners files for the nodejs code to document that @steven-supersolid

d339619

is handling the bulk of the code reviews (especially for style).

roberthbailey force-pushed the nodejs-owners branch from 3363f7a to d339619 Compare October 28, 2019 07:49

roberthbailey mentioned this pull request Oct 28, 2019

Document agones-allocator and multi-cluster allocation #1155

Merged

Merge branch 'master' into nodejs-owners

2447fe9

markmandel added the area/meta Organisational matters. e.g. Governance, release cycles, etc. label Oct 28, 2019

markmandel added this to the 1.1.0 milestone Oct 28, 2019

markmandel merged commit bc57333 into googleforgames:master Oct 28, 2019

roberthbailey deleted the nodejs-owners branch August 24, 2020 23:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add owners files for the nodejs code #1119

Add owners files for the nodejs code #1119

roberthbailey commented Oct 16, 2019

google-oss-robot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

google-oss-robot commented Oct 16, 2019

google-oss-robot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

pooneh-m commented Oct 16, 2019

roberthbailey commented Oct 16, 2019

roberthbailey commented Oct 20, 2019

markmandel commented Oct 25, 2019

roberthbailey commented Oct 25, 2019

roberthbailey commented Oct 25, 2019

roberthbailey commented Oct 25, 2019

roberthbailey commented Oct 25, 2019

agones-bot commented Oct 25, 2019

steven-supersolid commented Oct 26, 2019

agones-bot commented Oct 28, 2019

roberthbailey commented Oct 28, 2019

agones-bot commented Oct 28, 2019

agones-bot commented Oct 28, 2019

agones-bot commented Oct 28, 2019

agones-bot commented Oct 28, 2019

Add owners files for the nodejs code #1119

Add owners files for the nodejs code #1119

Conversation

roberthbailey commented Oct 16, 2019

google-oss-robot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

google-oss-robot commented Oct 16, 2019

google-oss-robot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

pooneh-m commented Oct 16, 2019

roberthbailey commented Oct 16, 2019

roberthbailey commented Oct 20, 2019

markmandel commented Oct 25, 2019

roberthbailey commented Oct 25, 2019

roberthbailey commented Oct 25, 2019

roberthbailey commented Oct 25, 2019

roberthbailey commented Oct 25, 2019

agones-bot commented Oct 25, 2019

steven-supersolid commented Oct 26, 2019

agones-bot commented Oct 28, 2019

roberthbailey commented Oct 28, 2019

agones-bot commented Oct 28, 2019

agones-bot commented Oct 28, 2019

agones-bot commented Oct 28, 2019

agones-bot commented Oct 28, 2019