Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran npm audit fix to update package dependencies. #1097

Merged
merged 2 commits into from
Oct 7, 2019

Conversation

roberthbailey
Copy link
Member

@steven-supersolid - While running lint and test on my other PR npm notified me that I had dependencies with security vulnerabilities. This PR updates dependencies to address them.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4cf80c0c-bc1b-48f8-91ca-c96a1888b7c7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1097/head:pr_1097 && git checkout pr_1097
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-e4a7674

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 91e6b19e-d41b-4ec5-87cf-f1acc3da035f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1097/head:pr_1097 && git checkout pr_1097
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-e7e1a50

@steven-supersolid
Copy link
Collaborator

LGTM however I wonder what's using handlebars - perhaps nyc for html display of coverage?
I'm currently on vacation so reviewing on a phone

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 30203f3d-dc26-47ac-b843-056bfe360485

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1097/head:pr_1097 && git checkout pr_1097
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-1c71a13

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit fb40130 into googleforgames:master Oct 7, 2019
@roberthbailey
Copy link
Member Author

I have no idea what's using it. Feel free to investigate & cull once you are back at work. In the mean time, I'll apply the update to close the security hole.

@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added area/security Issues pertaining to security kind/cleanup Refactoring code, fixing up documentation, etc labels Oct 22, 2019
@roberthbailey roberthbailey deleted the npm-audit-fix branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security Issues pertaining to security kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants