Sdkserver port configuration #1078

roberthbailey · 2019-09-26T08:07:51Z

First step of fixing #851.

I'm marking this as draft as I still need to do some testing.

agones-bot · 2019-09-26T08:16:05Z

Build Failed 😱

Build Id: 62834520-d08b-4491-891b-d6e09d03661a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-26T13:46:27Z

Build Failed 😱

Build Id: da5f5b5b-8f91-42ef-b80d-eeb080781250

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-26T16:07:41Z

Build Failed 😱

Build Id: 407e5e4c-4032-4db5-abf8-2d1ac4099dcc

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-26T22:42:15Z

Build Failed 😱

Build Id: bf51cc67-db8e-4134-82dc-5a71fc5206c5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-27T00:06:59Z

Build Succeeded 👏

Build Id: b43b7269-db4a-4a95-9ae8-1d2dbc22be25

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-c74dff0
image: gcr.io/agones-images/agones-sdk:1.1.0-c74dff0
image: gcr.io/agones-images/agones-ping:1.1.0-c74dff0
Linux C++ SDK (build): agonessdk-1.1.0-c74dff0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-c74dff0.zip

A preview of the website (the last 30 builds are retained):

https://c74dff0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1078/head:pr_1078 && git checkout pr_1078
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-c74dff0

roberthbailey · 2019-09-27T03:50:01Z

Ok, I've done some testing and this is now ready for review. Note that this only makes the ports configurable in the sdkserver, so currently you need to recompile the gameserver with a new SDK with a different port number to actually take advantage of this feature. I'll add SDK support in separate PRs (one per SDK to make them easier to review in parallel).

Testing cases:

Not setting port, existing SDK: works as before
Setting port, existing SDK: SDK fails to connect (expected) and gs in unhealthy
Setting port, recompiled SDK with new port: works as expected
Not setting port, recompiled SDK with new port: SDK fails to connect (expected) and gs in unhealthy

pkg/apis/agones/v1/gameserver.go

roberthbailey · 2019-09-27T03:54:38Z

/assign @markmandel
/assign @aLekSer

google-oss-robot · 2019-09-27T03:54:40Z

@roberthbailey: GitHub didn't allow me to assign the following users: aLekSer.

Note that only googleforgames members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @markmandel
/assign @aLekSer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

agones-bot · 2019-09-27T04:10:11Z

Build Succeeded 👏

Build Id: ea8026c8-f09a-455a-9818-1573f9936cb4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-492e857
image: gcr.io/agones-images/agones-sdk:1.1.0-492e857
image: gcr.io/agones-images/agones-ping:1.1.0-492e857
Linux C++ SDK (build): agonessdk-1.1.0-492e857-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-492e857.zip

A preview of the website (the last 30 builds are retained):

https://492e857-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1078/head:pr_1078 && git checkout pr_1078
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-492e857

agones-bot · 2019-09-27T04:18:06Z

Build Succeeded 👏

Build Id: 36ee0343-8c50-4f06-8281-01c28540f124

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-3f62f45
image: gcr.io/agones-images/agones-sdk:1.1.0-3f62f45
image: gcr.io/agones-images/agones-ping:1.1.0-3f62f45
Linux C++ SDK (build): agonessdk-1.1.0-3f62f45-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-3f62f45.zip

A preview of the website (the last 30 builds are retained):

https://3f62f45-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1078/head:pr_1078 && git checkout pr_1078
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-3f62f45

markmandel

Just to confirm - this doesn't cover the changes to the SDK(s) so it can connect to the specified ports. I assume that is coming in later PRs? (No problem if it is, just wanted to be sure)

pkg/apis/agones/v1/gameserver.go

site/content/en/docs/Reference/fleet.md

site/content/en/docs/Reference/gameserver.md

roberthbailey · 2019-09-27T17:15:46Z

Just to confirm - this doesn't cover the changes to the SDK(s) so it can connect to the specified ports. I assume that is coming in later PRs? (No problem if it is, just wanted to be sure)

Yes, that's what I was trying to explain here:

Note that this only makes the ports configurable in the sdkserver, so currently you need to recompile the gameserver with a new SDK with a different port number to actually take advantage of this feature. I'll add SDK support in separate PRs (one per SDK to make them easier to review in parallel).

pkg/apis/agones/v1/gameserver.go

roberthbailey · 2019-09-27T20:05:18Z

I've rebased, picking up the fix for the spacing issues in the website.

I think there are two outstanding questions:

Defaulting for the sdk server parameters: do we default logging, all, or none?
Name for the log level / logging parameter: do we change it from Logging to LogLevel?

agones-bot · 2019-09-27T20:09:17Z

Build Failed 😱

Build Id: 44f75acb-1ab1-4b1d-8565-71a22b131637

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2019-09-27T20:34:04Z

Defaulting for the sdk server parameters: do we default logging, all, or none?

I would default all. AFAIK, it seems to be the standard Kubernetes action, so that's what we've followed elsewhere. Also makes it easier to introspect what the values actually are from looking at that final GameServer configuration.

Name for the log level / logging parameter: do we change it from Logging to LogLevel?

I agree - LogLevel is better. 👍

agones-bot · 2019-09-27T20:55:41Z

Build Succeeded 👏

Build Id: 25e53c4e-c7e0-407a-b14d-6dce84d25d9a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-7b819a1
image: gcr.io/agones-images/agones-sdk:1.1.0-7b819a1
image: gcr.io/agones-images/agones-ping:1.1.0-7b819a1
Linux C++ SDK (build): agonessdk-1.1.0-7b819a1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-7b819a1.zip

A preview of the website (the last 30 builds are retained):

https://7b819a1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1078/head:pr_1078 && git checkout pr_1078
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-7b819a1

agones-bot · 2019-09-27T21:16:32Z

Build Failed 😱

Build Id: 551da6be-3203-4162-baf5-bf40c9b3a71a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-09-27T21:17:55Z

Build Failed 😱

Build Id: 40515703-a725-4f81-b720-933841a94151

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2019-09-27T21:21:24Z

This is ready for another review pass.

agones-bot · 2019-09-27T21:27:28Z

Build Failed 😱

Build Id: 100e245a-4044-471e-aaf0-2750bcb2d9cd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

Looks like you got caught by a linting fail, but this looks great! Nice job! 😀

google-oss-robot · 2019-09-27T22:33:50Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmandel, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

flags to make them configurable in the sdkserver. Changed the logging field into a type (from a string).

google-oss-robot · 2019-09-27T22:43:41Z

New changes are detected. LGTM label has been removed.

roberthbailey · 2019-09-27T22:44:09Z

Looks like you got caught by a linting fail,

I still haven't figured out how to get GoLand to run gofmt on save.

agones-bot · 2019-09-27T23:07:12Z

Build Succeeded 👏

Build Id: 33cb6287-e5a5-4a22-b297-0dcaf3892b5a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-8e1af2d
image: gcr.io/agones-images/agones-sdk:1.1.0-8e1af2d
image: gcr.io/agones-images/agones-ping:1.1.0-8e1af2d
Linux C++ SDK (build): agonessdk-1.1.0-8e1af2d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-8e1af2d.zip

A preview of the website (the last 30 builds are retained):

https://8e1af2d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1078/head:pr_1078 && git checkout pr_1078
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-8e1af2d

google-oss-robot added do-not-merge/work-in-progress size/L labels Sep 26, 2019

roberthbailey force-pushed the sdkserver-port-configuration branch from dac6ec3 to 35fceec Compare September 26, 2019 13:38

roberthbailey force-pushed the sdkserver-port-configuration branch from 35fceec to d30b3b9 Compare September 26, 2019 15:57

roberthbailey force-pushed the sdkserver-port-configuration branch from d30b3b9 to bbdf578 Compare September 26, 2019 22:30

roberthbailey force-pushed the sdkserver-port-configuration branch from bbdf578 to c74dff0 Compare September 26, 2019 23:44

roberthbailey force-pushed the sdkserver-port-configuration branch from c74dff0 to 492e857 Compare September 27, 2019 03:47

roberthbailey marked this pull request as ready for review September 27, 2019 03:47

google-oss-robot removed the do-not-merge/work-in-progress label Sep 27, 2019

roberthbailey commented Sep 27, 2019

View reviewed changes

pkg/apis/agones/v1/gameserver.go Show resolved Hide resolved

google-oss-robot assigned markmandel Sep 27, 2019

roberthbailey force-pushed the sdkserver-port-configuration branch from 492e857 to 3f62f45 Compare September 27, 2019 03:55

markmandel reviewed Sep 27, 2019

View reviewed changes

roberthbailey commented Sep 27, 2019

View reviewed changes

pkg/apis/agones/v1/gameserver.go Outdated Show resolved Hide resolved

roberthbailey force-pushed the sdkserver-port-configuration branch from 3f62f45 to aea976b Compare September 27, 2019 19:58

roberthbailey force-pushed the sdkserver-port-configuration branch from aea976b to 7b819a1 Compare September 27, 2019 20:31

roberthbailey force-pushed the sdkserver-port-configuration branch 2 times, most recently from 56c0ca2 to 4243761 Compare September 27, 2019 21:09

roberthbailey force-pushed the sdkserver-port-configuration branch from 4243761 to f63f25e Compare September 27, 2019 21:19

markmandel approved these changes Sep 27, 2019

View reviewed changes

google-oss-robot added the lgtm label Sep 27, 2019

roberthbailey added 6 commits September 27, 2019 15:40

Add parameters for the gRPC and HTTP ports along with command line

f297124

flags to make them configurable in the sdkserver. Changed the logging field into a type (from a string).

Updated CRD validation.

6d8d234

Run make gen-install.

d4600e5

Updates to example yaml files.

a581577

Updates to the reference documentation for the new API fields.

54ea7ca

Ran make gen-api-docs.

8e1af2d

roberthbailey force-pushed the sdkserver-port-configuration branch from f63f25e to 8e1af2d Compare September 27, 2019 22:43

google-oss-robot removed the lgtm label Sep 27, 2019

roberthbailey merged commit 03eb7b1 into googleforgames:master Sep 27, 2019

roberthbailey mentioned this pull request Oct 2, 2019

YAML installation is broken due to sdkServer validation failure #1090

Closed

markmandel added this to the 1.1.0 milestone Oct 22, 2019

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Oct 22, 2019

roberthbailey deleted the sdkserver-port-configuration branch August 24, 2020 23:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sdkserver port configuration #1078

Sdkserver port configuration #1078

roberthbailey commented Sep 26, 2019

agones-bot commented Sep 26, 2019

agones-bot commented Sep 26, 2019

agones-bot commented Sep 26, 2019

agones-bot commented Sep 26, 2019

agones-bot commented Sep 27, 2019

roberthbailey commented Sep 27, 2019

roberthbailey commented Sep 27, 2019

google-oss-robot commented Sep 27, 2019

agones-bot commented Sep 27, 2019

agones-bot commented Sep 27, 2019

markmandel left a comment

roberthbailey commented Sep 27, 2019

roberthbailey commented Sep 27, 2019

agones-bot commented Sep 27, 2019

markmandel commented Sep 27, 2019

agones-bot commented Sep 27, 2019

agones-bot commented Sep 27, 2019

agones-bot commented Sep 27, 2019

roberthbailey commented Sep 27, 2019

agones-bot commented Sep 27, 2019

markmandel left a comment

google-oss-robot commented Sep 27, 2019

google-oss-robot commented Sep 27, 2019

roberthbailey commented Sep 27, 2019

agones-bot commented Sep 27, 2019

Sdkserver port configuration #1078

Sdkserver port configuration #1078

Conversation

roberthbailey commented Sep 26, 2019

agones-bot commented Sep 26, 2019

agones-bot commented Sep 26, 2019

agones-bot commented Sep 26, 2019

agones-bot commented Sep 26, 2019

agones-bot commented Sep 27, 2019

roberthbailey commented Sep 27, 2019

roberthbailey commented Sep 27, 2019

google-oss-robot commented Sep 27, 2019

agones-bot commented Sep 27, 2019

agones-bot commented Sep 27, 2019

markmandel left a comment

Choose a reason for hiding this comment

roberthbailey commented Sep 27, 2019

roberthbailey commented Sep 27, 2019

agones-bot commented Sep 27, 2019

markmandel commented Sep 27, 2019

agones-bot commented Sep 27, 2019

agones-bot commented Sep 27, 2019

agones-bot commented Sep 27, 2019

roberthbailey commented Sep 27, 2019

agones-bot commented Sep 27, 2019

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Sep 27, 2019

google-oss-robot commented Sep 27, 2019

roberthbailey commented Sep 27, 2019

agones-bot commented Sep 27, 2019