Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactoring of the simple udp server. #1062

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Small refactoring of the simple udp server. #1062

merged 2 commits into from
Sep 23, 2019

Conversation

roberthbailey
Copy link
Member

I was working on copying this file into a simple tcp server to add some new e2e tests and I noticed that one function was not like the others so I figured I'd send a small change to make things consistent. I didn't bother bumping the container image number as I figured we can just pick this up on the next change.

/assign @markmandel

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 188f6f35-22c2-4a1e-b598-e81bd67aa01f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

cyriltovena
cyriltovena approved these changes Sep 22, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cyriltovena, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added this to the 1.1.0 milestone Sep 23, 2019
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e180523b-a563-4320-a5c1-682087545d53

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1062/head:pr_1062 && git checkout pr_1062
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-3245408

@markmandel markmandel merged commit a972b6b into googleforgames:master Sep 23, 2019
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 22, 2019
@roberthbailey roberthbailey deleted the simple-udp branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees

@markmandel markmandel

@cyriltovena cyriltovena

Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@roberthbailey @agones-bot @google-oss-robot @cyriltovena @markmandel