Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the required version of terraform. #1006

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

roberthbailey
Copy link
Member

This was missed in #899 (and should be live now so it isn't version guarded).

@markmandel markmandel added kind/bug These are bugs. kind/documentation Documentation for Agones labels Aug 20, 2019
@markmandel
Copy link
Member

So just to be 100% clear - the older version of terraform no longer works?

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 32ebb32a-19ee-41b7-bfd8-22ade4e0930a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1006/head:pr_1006 && git checkout pr_1006
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-97ed169

@roberthbailey
Copy link
Member Author

So just to be 100% clear - the older version of terraform no longer works?

Correct. I tried using the older version and terraform apply gives an error (I don't recall which one) because we've started using syntax that was introduced in 0.12.

Also note that the terraform module linked from the guide pulls the agones configs from the master branch, so this has been broken since #889 was submitted.

/cc @aLekSer

@markmandel markmandel added this to the 1.0 milestone Aug 21, 2019
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markmandel markmandel merged commit 4c0736a into googleforgames:master Aug 21, 2019
@roberthbailey roberthbailey deleted the terraform-version branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants