Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller logging consistency #456

Closed
Oleksii-Terekhov opened this issue Dec 24, 2018 · 2 comments
Closed

Controller logging consistency #456

Oleksii-Terekhov opened this issue Dec 24, 2018 · 2 comments
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc
Milestone
0.7.0

Comments

@Oleksii-Terekhov
Copy link

We use centralized k8s log collectors (try and fluentd, and filebeat) with store logs to Elasticsearh.

Agones controller send field gs sometimes as empty string (""), sometimes as dict ("gs":map[string]interface {}{"metadata":map[string]interface {}{"generateName":....)

Filebeat drop whole log string with wrong type, Fluentd drop only fileds with type conflicts.

Bug: wrong logging architecture
@markmandel
Copy link
Member

markmandel commented Dec 24, 2018 •
edited
Loading

We definitely have places where "gs" is the full gameserver, and I think we also have "patch" in admission controllers.

I feel like we should relegate full object json dumps to Debug() level logging, and cleanup the "gs" logs to just output the name of the GameServer -- which is what we have in most(?) places.

@markmandel markmandel added help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! kind/cleanup Refactoring code, fixing up documentation, etc labels Dec 24, 2018
@markmandel
Copy link
Member

Looking into this more - we should likely be using the FluentdFormatter formatter:
https://github.com/joonix/log

Change to be made here:
https://github.com/GoogleCloudPlatform/agones/blob/master/pkg/util/runtime/runtime.go#L37

markmandel added a commit to markmandel/agones that referenced this issue Dec 28, 2018
@markmandel
Convert to using Fluentdformatter
3ca0554 
This is the technically correct implementation
for Fluentd and for GKE.

Closes googleforgames#456
@markmandel markmandel mentioned this issue Dec 28, 2018
Merged
markmandel added a commit that referenced this issue Dec 28, 2018
@markmandel
Convert to using Fluentdformatter
018972d 
This is the technically correct implementation
for Fluentd and for GKE.

Closes #456
@markmandel markmandel added this to the 0.7.0 milestone Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@markmandel @Oleksii-Terekhov