Flaky test: fleetautoscaler_test.go #2296
Labels
good first issue
These are great first issues. If you are looking for a place to start, start here!
help wanted
We would love help on these issues. Please come help us!
kind/bug
These are bugs.
Milestone
Comments
roberthbailey
added
kind/bug
markmandel
changed the title
|
Another instance (from a different PR). |
markmandel
added a commit
to markmandel/agones
that referenced
this issue
Oct 8, 2021
I noticed in a few flaky end-to-end tests, I kept seeing this in the logs: ``` time="2021-10-08 19:02:01.419" level=info msg="sent UDP packet" address="35.247.94.25:7682" test=TestGameServerUnhealthyAfterReadyCrash ``` Over and over again, and also noting that it was happening _after_ the e2e test had completed. See: https://console.cloud.google.com/cloud-build/builds/9ca5715a-443c-4693-bbd5-2879e61f2aaa;step=21?project=agones-images https://console.cloud.google.com/cloud-build/builds/84cb8db2-1a11-4db3-a9e1-d9d51b9baf14;step=21?project=agones-images My theory: The go routine had nothing in it that forced it to stop once the test was complete - so depending on order of tests, it might keep continuing for a while, while other tests ran. If it did that, and a GameServer spun up on the same node and port as the originally crashed GameServer, it would crash it - likely breaking whatever test it ran into! Work on googleforgames#2296
markmandel
added a commit
to markmandel/agones
that referenced
this issue
Oct 8, 2021
Added the test name to the e2e framework logging around Fleets, so it should hopefully make things a bit easier to debug flaky tests. Work on googleforgames#2296
roberthbailey
pushed a commit
that referenced
this issue
Oct 8, 2021
Added the test name to the e2e framework logging around Fleets, so it should hopefully make things a bit easier to debug flaky tests. Work on #2296
roberthbailey
added a commit
that referenced
this issue
Oct 11, 2021
I noticed in a few flaky end-to-end tests, I kept seeing this in the logs: ``` time="2021-10-08 19:02:01.419" level=info msg="sent UDP packet" address="35.247.94.25:7682" test=TestGameServerUnhealthyAfterReadyCrash ``` Over and over again, and also noting that it was happening _after_ the e2e test had completed. See: https://console.cloud.google.com/cloud-build/builds/9ca5715a-443c-4693-bbd5-2879e61f2aaa;step=21?project=agones-images https://console.cloud.google.com/cloud-build/builds/84cb8db2-1a11-4db3-a9e1-d9d51b9baf14;step=21?project=agones-images My theory: The go routine had nothing in it that forced it to stop once the test was complete - so depending on order of tests, it might keep continuing for a while, while other tests ran. If it did that, and a GameServer spun up on the same node and port as the originally crashed GameServer, it would crash it - likely breaking whatever test it ran into! Work on #2296 Co-authored-by: Robert Bailey <[email protected]>
|
I think we can close this now? Seems like we've fixed it! |
|
Looks like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A spelling fix for the website failed e2e tests
Build log
The text was updated successfully, but these errors were encountered: