Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agones Game Server Client SDKs #1854

Closed
Natanil opened this issue Oct 20, 2020 · 2 comments · Fixed by #1912
Closed

Agones Game Server Client SDKs #1854

Natanil opened this issue Oct 20, 2020 · 2 comments · Fixed by #1912
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs. kind/documentation Documentation for Agones
Milestone
1.11.0

Comments

@Natanil
Copy link

Natanil commented Oct 20, 2020

You mistakenly write the explanation of Alpha().IsPlayerConnected(playerID) to Alpha().GetPlayerCount() explanation :

Alpha().GetPlayerCount()
This function returns if the playerID is currently connected to the GameServer. This is always accurate from what has been set through this SDK, even if the value has yet to be updated on the GameServer status resource.

Alpha().IsPlayerConnected(playerID)
This function returns if the playerID is currently connected to the GameServer. This is always accurate from what has been set through this SDK, even if the value has yet to be updated on the GameServer status resource.
@markmandel markmandel added good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs. kind/documentation Documentation for Agones labels Oct 20, 2020
@markmandel
Copy link
Member

Thanks for the catch! if you get a chance, please file a PR!

@Natanil
Copy link
Author

Natanil commented Oct 25, 2020 •
edited
Loading

Dear Mark, I live in Iran, which the US government entirely sanctions, and I think I don't have permission to get the CLA, and I can't even use the google cloud recently.
I hope one-day Iranian developers have the right to participate as others do.
Thanks for your contribution to such a beneficial platform.

@NomadicBits NomadicBits mentioned this issue Nov 29, 2020
Merged
markmandel added a commit that referenced this issue Dec 2, 2020
@NomadicBits @markmandel
Issue #1854: Fix getplayercount() description on index (#1912)
8cf7442 
* Fix Getplayercount discription to match the rest api

* Update Guides/ClientSDKS/index GetPlayerCount() add alert back in

Co-authored-by: Mark Mandel <[email protected]>
@markmandel markmandel added this to the 1.11.0 milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs. kind/documentation Documentation for Agones
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

Issue #1854: Fix getplayercount() description on index
2 participants
@markmandel @Natanil