GameServerTemplate validation: no description when used big port values

[aLekSer]

What happened:
Inconsistent error message when using a big value for grpcPort field grpcPort: 33332229357.

The Fleet "" is invalid

What you expected to happen:
Consistent error message without dependency on port field length.

How to reproduce it (as minimally and precisely as possible):

Change example/fleet.yaml lines starting from 65 to :

      sdkServer:
        # sdkServer log level parameter has three options:
        #  - "Info" (default) The SDK server will output all messages except for debug messages
        #  - "Debug" The SDK server will output all messages including debug messages
        #  - "Error" The SDK server will only output error messages
        logLevel: Info
        grpcPort: 33332229357
        httpPort: 9358

kubectl apply -f resulted fleet:

The Fleet "" is invalid

Do the same with smaller grpcPort value 2229357:

spec.template.spec.sdkServer.grpcPort in body should be less than or equal to 65535

Anything else we need to know?:

Environment:

• Agones version: 1.8 (master)
• Kubernetes version (use kubectl version): 1.15
• Cloud provider or hardware configuration:
• Install method (yaml/helm): Terraform Helm
• Troubleshooting guide log(s):
• Others:

[aLekSer]

I assume that this bug is more general and specific to Helm templates and out of scope of Agones. Need more investigation.

[markmandel]

We should retest this.

The https://github.com/googleforgames/agones/blob/main/install/helm/agones/templates/crds/_gameserverspecschema.yaml has min/max values, so in theory, you should get good validation - but we are leaning on K8s to provide it. Not sure how much control we have in Agones.

[roberthbailey]

I just tried this with an install of Agones 1.25.0 and the error message still doesn't tell us what is invalid, just that it is:

$ kubectl apply -f fleet.yaml
The Fleet "fleet-example" is invalid

[roberthbailey]

I've installed the latest release (1.28.0) and the behavior is the same as was originally reported:

# grpcPort: 33332229357
$ kubectl apply -f fleet.yaml 
The Fleet "fleet-example" is invalid
# grpcPort: 2229357
$ kubectl apply -f fleet2.yaml 
The Fleet "fleet-example" is invalid: spec.template.spec.sdkServer.grpcPort: Invalid value: 2229357: spec.template.spec.sdkServer.grpcPort in body should be less than or equal to 65535

My guess is that the small number is convertible to an integer type (which can then be compared to the min/max values) whereas the larger number overflows and as such can not be converted to an integer type at all, producing the generic error message.

[zmerlynn]

I stumbled into this the other day and put up #2863, but I'm playing with a slightly different mechanism now. It seems weird that the OpenAPI validation isn't catching this, but I think that create webhooks take place before schema validation - so I'm also trying to see if we just "fail open" in creation webhooks when the JSON can't be unmarshalled whether we get the nice OpenAPI errors.