Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site: fix obsolete links of Kubernetes API v1.13 in Autogenerated Agones CRD API reference #1617

Closed
aLekSer opened this issue Jun 5, 2020 · 0 comments · Fixed by #1621
Closed

Site: fix obsolete links of Kubernetes API v1.13 in Autogenerated Agones CRD API reference #1617

aLekSer opened this issue Jun 5, 2020 · 0 comments · Fixed by #1621
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Milestone
1.7.0

Comments

@aLekSer
Copy link
Collaborator

aLekSer commented Jun 5, 2020 •
edited
Loading

There are lots of 404 links like:

<a href="https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#objectmeta-v1-meta">

https://github.com/googleforgames/agones/blob/16ce6ce2856b0131bb170c0559ae6711478fa582/site/content/en/docs/Reference/agones_crd_api_reference.html
And here
https://github.com/googleforgames/agones/blob/b37ad7407687f2d2d6e1ee596242f3479ab00026/site/content/en/docs/Advanced/limiting-resources.md
What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Agones version:
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • Install method (yaml/helm):
  • Troubleshooting guide log(s):
  • Others:
@aLekSer aLekSer added the kind/bug These are bugs. label Jun 5, 2020
@aLekSer aLekSer changed the title Site: fix obsolete links in Autogenerated Agones CRD API reference Site: fix obsolete links of Kubernetes API v1.13 in Autogenerated Agones CRD API reference Jun 10, 2020
markmandel added a commit to markmandel/agones that referenced this issue Jun 10, 2020
@markmandel
Fix 404 in CRD generated documentation.
3103de4 
- Updated gen-crd-api-reference-docs
- Added our own config to point to the version of K8s we want.
- Manually updated the older CRD ref to point to 1.15, since it doesn't
get updated automatically.
- Added the ability to the htmltest config to disable external testing,
  for easier local dev testing.

Closes googleforgames#1617
@markmandel markmandel mentioned this issue Jun 10, 2020
Merged
markmandel added a commit to markmandel/agones that referenced this issue Jun 10, 2020
@markmandel
Fix 404 in CRD generated documentation.
3325758 
- Updated gen-crd-api-reference-docs
- Added our own config to point to the version of K8s we want.
- Manually updated the older CRD ref to point to 1.15, since it doesn't
get updated automatically.
- Added the ability to the htmltest config to disable external testing,
  for easier local dev testing.

Closes googleforgames#1617
markmandel added a commit to markmandel/agones that referenced this issue Jun 10, 2020
@markmandel
Fix 404 in CRD generated documentation.
71cb85c 
- Updated gen-crd-api-reference-docs
- Added our own config to point to the version of K8s we want.
- Manually updated the older CRD ref to point to 1.15, since it doesn't
get updated automatically.
- Added the ability to the htmltest config to disable external testing,
  for easier local dev testing.

Closes googleforgames#1617
markmandel added a commit to markmandel/agones that referenced this issue Jun 10, 2020
@markmandel
Fix 404 in CRD generated documentation.
8f37755 
- Updated gen-crd-api-reference-docs
- Added our own config to point to the version of K8s we want.
- Manually updated the older CRD ref to point to 1.15, since it doesn't
get updated automatically.
- Added the ability to the htmltest config to disable external testing,
  for easier local dev testing.

Closes googleforgames#1617
markmandel added a commit that referenced this issue Jun 10, 2020
@markmandel
Fix 404 in CRD generated documentation. (#1621)
58a0746 
- Updated gen-crd-api-reference-docs
- Added our own config to point to the version of K8s we want.
- Manually updated the older CRD ref to point to 1.15, since it doesn't
get updated automatically.
- Added the ability to the htmltest config to disable external testing,
  for easier local dev testing.

Closes #1617
@markmandel markmandel added the kind/documentation Documentation for Agones label Jun 10, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jun 10, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this issue Oct 23, 2020
@markmandel @ilkercelikyilmaz
Fix 404 in CRD generated documentation. (googleforgames#1621)
5a9803e 
- Updated gen-crd-api-reference-docs
- Added our own config to point to the version of K8s we want.
- Manually updated the older CRD ref to point to 1.15, since it doesn't
get updated automatically.
- Added the ability to the htmltest config to disable external testing,
  for easier local dev testing.

Closes googleforgames#1617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Fix 404 in CRD generated documentation. markmandel/agones
2 participants
@markmandel @aLekSer