Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /site to go.mod and Go 1.12/1.13 #1295

Closed
markmandel opened this issue Jan 24, 2020 · 3 comments · Fixed by #1457
Closed

Move /site to go.mod and Go 1.12/1.13 #1295

markmandel opened this issue Jan 24, 2020 · 3 comments · Fixed by #1457
Assignees
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/site The website itself - including redirects, styling, search, etc kind/cleanup Refactoring code, fixing up documentation, etc
Milestone

Comments

@markmandel
Copy link
Member

https://github.com/googleforgames/agones/tree/master/site

We do some gopath shenanigans to create and deploy the site:
https://github.com/googleforgames/agones/blob/master/build/includes/website.mk#L50
https://github.com/googleforgames/agones/blob/master/site/cloudbuild.yaml#L42

Which we don't need to do anymore (and bit me the other day during release).

We could move this to a go.mod and also update the App Engine version to a later version of go (currently 1.11) with minimal difficulty, and it would make this process much easier.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/site The website itself - including redirects, styling, search, etc labels Jan 24, 2020
@markmandel
Copy link
Member Author

@heartrobotninja still keen on taking this on?

@heartrobotninja
Copy link
Contributor

heartrobotninja commented Jan 25, 2020 via email

@markmandel
Copy link
Member Author

Thanks!

/assign @heartrobotninja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/site The website itself - including redirects, styling, search, etc kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants