ObjectMeta should use additionalProperties

Rather than using `x-kubernetes-preserve-unknown-fields` which allows both keys and values of any type, we should use `additionalProperties` which only allows a specified type (in this case "string") for keys and values. Better validation!
googleforgames · Jan 14, 2021 · 3dea765 · 3dea765
1 parent 7a4d1bc
commit 3dea765
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/install/helm/agones/templates/crds/_gameserverspecschema.yaml b/install/helm/agones/templates/crds/_gameserverspecschema.yaml
@@ -24,10 +24,12 @@ properties:
     properties:
       labels:
         type: object
-        x-kubernetes-preserve-unknown-fields: true
+        additionalProperties:
+          type: string
       annotations:
         type: object
-        x-kubernetes-preserve-unknown-fields: true
+        additionalProperties:
+          type: string
   {{- end}}
   spec:
     type: object