Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split kerning by script, not by direction #636

Merged
merged 17 commits into from
Jul 21, 2022
Merged

Split kerning by script, not by direction #636

merged 17 commits into from
Jul 21, 2022

Commits on Jul 20, 2022

  1. Allow classify_glyphs to handle its classifying function returning mo… 

    …re than one category
    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    c8941f6 View commit details
    Browse the repository at this point in the history

  2. Allow kerning pairs to be constructed from lists of glyph names, not … 

    …just ast nodes
    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    75f8a32 View commit details
    Browse the repository at this point in the history

  3. Allow access to each element of a pair

    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    1f48337 View commit details
    Browse the repository at this point in the history

  4. Add partitionByScript method 

    Given a pair and mapping between glyph names and a set of scripts, split the pair into (potentially) multiple pairs each with a dominant script.
    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    ac5ddb3 View commit details
    Browse the repository at this point in the history

  5. A test for the partition-pair-by-script logic

    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    e2a0cb1 View commit details
    Browse the repository at this point in the history

  6. Split kerning by script

    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    f56eaf6 View commit details
    Browse the repository at this point in the history

  7. Only classify glyphs into known scripts, or common if there are no sc… 

    …ripts defined
    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    9a5023c View commit details
    Browse the repository at this point in the history

  8. Fix test expectations

    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    c236de0 View commit details
    Browse the repository at this point in the history

  9. Flake fixes

    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    650498b View commit details
    Browse the repository at this point in the history

  10. Fix bad feaLib AST usage

    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    1e5a043 View commit details
    Browse the repository at this point in the history

  11. Not my lint

    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    f8a688c View commit details
    Browse the repository at this point in the history

  12. Use constant for Zyyy

    @simoncozens
    simoncozens committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    f8f70f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Address the easy bit of the feedback

    @simoncozens
    simoncozens committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    4280397 View commit details
    Browse the repository at this point in the history

  2. Emit the lookup references in a friendlier order

    @simoncozens
    simoncozens committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    33560c3 View commit details
    Browse the repository at this point in the history

  3. Fix test expectations (reordering)

    @simoncozens
    simoncozens committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    69aa0a1 View commit details
    Browse the repository at this point in the history

  4. Check logging of mixed script pair problems

    @simoncozens
    simoncozens committed Jul 21, 2022
    2 Configuration menu
    Copy the full SHA
    85003f4 View commit details
    Browse the repository at this point in the history

  5. Inheritable logger name

    @simoncozens
    simoncozens committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    f97e791 View commit details
    Browse the repository at this point in the history