You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
when converting from .glyphs to UFO, glyphsLib generates a GDEF GlyphClassDef table (with Base, Mark, Ligature glyphs) based on the GlyphData.xml properties.
Now, ufo2ft uses a GDEF table (if present in the UFO features.fea) when generating mark and mkmk features. If a GDEF table definition is present in features.fea, then it only considers as bases/marks/ligatures the glyphs that are listed in the GDEF; those that aren't are simply excluded from the mark and mkmk lookups.
The problem is that, even if bracket layers contain some anchors (and the user expects these anchors to be used for generating mark/mkmk), glyphsLib is not considering these when auto-generating the GDEF table definition. This is because it generates this GDEF before it actually converts the bracket layers to standalone UFO glyphs. As it generates the GDEF, the bracket "glyphs" are not there yet, so they are not considered; by the time it has applied the bracket layers (copying them over to standalone glyphs), it is too late for them to be included in GDEF.
We need to reorder the logic here and make sure that GDEF contains the newly added bracket glyphs.
The text was updated successfully, but these errors were encountered:
anthrotype
added a commit
to anthrotype/glyphsLib
that referenced
this issue
Jan 29, 2020
when converting from .glyphs to UFO, glyphsLib generates a GDEF GlyphClassDef table (with Base, Mark, Ligature glyphs) based on the GlyphData.xml properties.
Now, ufo2ft uses a GDEF table (if present in the UFO features.fea) when generating mark and mkmk features. If a GDEF table definition is present in features.fea, then it only considers as bases/marks/ligatures the glyphs that are listed in the GDEF; those that aren't are simply excluded from the mark and mkmk lookups.
The problem is that, even if bracket layers contain some anchors (and the user expects these anchors to be used for generating mark/mkmk), glyphsLib is not considering these when auto-generating the GDEF table definition. This is because it generates this GDEF before it actually converts the bracket layers to standalone UFO glyphs. As it generates the GDEF, the bracket "glyphs" are not there yet, so they are not considered; by the time it has applied the bracket layers (copying them over to standalone glyphs), it is too late for them to be included in GDEF.
We need to reorder the logic here and make sure that GDEF contains the newly added bracket glyphs.
The text was updated successfully, but these errors were encountered: