Magic contour selection #1704
Open
Magic contour selection #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is not yet a solid code review, but I found one small issue.
However, there is a bigger thing missing: whenever the "magic behavior" is active (regardless of how we decide to activate it), the user should see what will be selected once they click. In other words, this is missing "hover" behavior. It should set sceneController.hoverSelection appropriately while hovering.
| } | ||
| const selection = this._selectionBeforeSingleClick || sceneController.selection; | ||
| this._selectionBeforeSingleClick = undefined; | ||
| const modeFunc = selectModeFunction(event); |
There was a problem hiding this comment.
While refactoring this bit of code, you forgot to pass event down. This is now falling back to window.event, which is probably just accidentally working. (window.event is a deprecated property.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pull request for magic contour selection with the pointer tool.
By holding the cmd (metaKey) modifier key:
Note:
In
path-hit-tester.js->PathHitTester->findNearest, I commented out line 65:results = results.filter((hit) => hit.t != 0 && hit.t != 1);This line restricts findNearest to only work when, in the case of a rectangular shape, the cursor's x value is between the rectangle's xmin and xmax, or the y value is between its ymin and ymax.
This function is used exclusively with the power ruler tool and now the pointer tool. Commenting out this line seems to have no effect on the power ruler tool.