Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .ufoz (UFO compressed ZIP format) #887

Closed
NightFurySL2001 opened this issue May 29, 2022 · 4 comments · Fixed by #900 or #905
Closed

Add support for .ufoz (UFO compressed ZIP format) #887

NightFurySL2001 opened this issue May 29, 2022 · 4 comments · Fixed by #900 or #905

Comments

@NightFurySL2001
Copy link
Contributor

NightFurySL2001 commented May 29, 2022

According to UFO 3 Specification, a UFO folder may be compressed into a ZIP format file with the extension .ufoz. fontmake currently does not support it with the following error: fontmake: error: Unknown input file extension: xxx.ufoz

This will be a very good addition as CJK fonts that need to go up on Google Fonts has tens of thousands of glyphs that uploading the UFO folder is painstakeningly slow (without resorting to using Mac and Glyphs).

@NightFurySL2001
Copy link
Contributor Author

Seems like ufoLib2 can open .ufoz files.

@anthrotype
Copy link
Member

reopening as

#900 PR only adds support for reading .ufoz when passed in to the fontmake CLI without the explicit -u flag.
What's left to do for #887 is also allow ufoz as an additional output format for -o option. That would only be relevant for .glyphs inputs, of course (i.e. if one wants to convert a .glyphs file to a Designspace file + a set of .ufoz masters).

@NightFurySL2001
Copy link
Contributor Author

Also noted that UFO will be generated when doing interpolation between UFO(Z) masters.

instance_ufo.save()

This will require verifying glyphsLib does support .ufoz file which I am unable to do at the moment.

@NightFurySL2001
Copy link
Contributor Author

NightFurySL2001 commented Jul 1, 2022

Actually just noticed there's this line that will need additional support for UFOZ too:

key = os.path.basename(master_path).rstrip(".ufo")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants