[read-fonts] initial codegen for parsing sbix table #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting work on bitmap support and figured I'd tackle the low hanging fruit first. This includes basic codegen for parsing sbix along with a tiny helper method to load `GlyphData` for a given glyph id. Working towards #593
cmyr
approved these changes
Sep 12, 2023
resources/codegen_inputs/sbix.rs
Outdated
| /// Bit 0: Set to 1. | ||
| /// Bit 1: Draw outlines. | ||
| /// Bits 2 to 15: reserved (set to 0). | ||
| flags: u16, |
There was a problem hiding this comment.
we might want to define a flags type for this?
There was a problem hiding this comment.
Good call. The unnamed bit 0 that must always be set to 1 seems problematic for the codegen flags type. Wdyt about wrapping in a record and implementing default and appropriate methods for the “render outlines bit” instead?
There was a problem hiding this comment.
I think an easier option would be to use flags, but use the compile_with annotation to provide a fn that ensures that bit one is always set when writing.
There was a problem hiding this comment.
Since I'm adding compile_with, went ahead and extended this for write support. Should be good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting work on bitmap support and figured I'd tackle the low hanging fruit first. This includes basic codegen for parsing sbix along with a tiny helper method to load
GlyphDatafor a given glyph id.Working towards #593