Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Robotics Core is incompatible with --incompatible_load_proto_rules_from_bzl #24

Closed
Yannic opened this issue Dec 16, 2019 · 2 comments · Fixed by #438
Closed

Cloud Robotics Core is incompatible with --incompatible_load_proto_rules_from_bzl #24

Yannic opened this issue Dec 16, 2019 · 2 comments · Fixed by #438
Labels
build build system related

Comments

@Yannic
Copy link
Contributor

Yannic commented Dec 16, 2019

Hello maintainers of Cloud Robotics Core 👋,

The Bazel team is in progress of migrating the native Protobuf rules to Starlark. As a first step towards this goal, starting with Bazel 3.0, all Protobuf rules will require explicit load statements.

You can use the following buildifier command to apply most of the required migrations for you:

buildifier --lint=fix --warnings=native-proto $(find . -name "BUILD" -o -name "BUILD.bazel" -o -name "*.bzl")

For further information, see bazelbuild/bazel#8922 or ping me.

Thanks,
Yannic

@drigz drigz self-assigned this Dec 18, 2019
@drigz
Copy link
Contributor

drigz commented Dec 18, 2019

@Yannic, we depend on rules_go, which doesn't appear to have updated: bazel-contrib/rules_go#2266

If I understand correctly, it's impossible for us to be compliant until there is a compliant rules_go update available. Let me know if I'm mistaken.

@Yannic
Copy link
Contributor Author

Yannic commented Dec 18, 2019

Yes, all (transitive) dependencies also need to become compliant for this repo to become fully compliant.
I submitted a patch to bazel-contrib/bazel-gazelle#683 today, which makes go_repository compliant. When that PR is merged, I'll look into finishing bazel-contrib/rules_go#2315.

@ensonic ensonic added the build build system related label May 26, 2020
ensonic added a commit that referenced this issue Sep 19, 2024
Ran:
```
buildifier --lint=fix --warnings=native-proto $(find . -name "BUILD.bazel" -o -name "*.bzl")
```

Fixes: #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build system related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants