Skip to content
This repository has been archived by the owner on Nov 5, 2022. It is now read-only.

Create package:pedantic. #1

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Conversation

davidmorgan
Copy link
Contributor

No description provided.

README.md Outdated
lint we first clean up all pre-existing violations. After it's enabled, any
attempt to check in a further violation will be blocked.

The currently enabled lints are:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than duplicate all of this (so that changes have to be made in two places), consider just pointing readers to the sample analysis options file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree with de-duping, but I think the md file is a nicer place to talk about reasons for not enforcing particular lints. So I put the enforced lints just in the yaml file and the not enforced lints just in the README. What do you think, please?

Thanks :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine. You can always change it if you discover that it isn't working well for you :-) After all, you're the one who'll be maintaining this (at least for a while).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite :)

Thanks!

Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@davidmorgan davidmorgan merged commit 02a6fb0 into googlearchive:master Aug 23, 2018
@davidmorgan davidmorgan deleted the setup branch August 23, 2018 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants