Exports for Node.js and Browserify #67
Conversation
Has with backwards-compatibility for the old `require()` API. If we're in the browser, export as a standard global object.
|
Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide. |
|
Thanks for signing the CLA! |
|
No problem. Also you might want to update the contributing guidelines for this repo since right now it points to a broken link. |
|
👍 |
|
wonder when is this going to be merged.. |
| global.Observer.hasObjectObserve = hasObserve; | ||
| global.ArrayObserver = ArrayObserver; | ||
| global.ArrayObserver.calculateSplices = function(current, previous) { | ||
| // Export the observe-js object for **Node.js**, with |
There was a problem hiding this comment.
is there a reason to have the ** around Node.js?
|
@wmira -- doh, I guess the assigned reviewer didn't notice it. I've assigned it to myself. @victorsigma -- apologies for taking so long to get to this! If you're still around, I added some comments. We can also just merge this and I could make the suggested tweaks (but they're very minor so not a big deal). Mostly I'm just wondering your thoughts, and for my own knowledge if there's a standard style we can use for this sort of cross browser/node.js module. |
|
LGTM. thanks again. |
Exports for Node.js and Browserify
|
@jmesserly this should work for me. any chance we get the npm build updated? |
Has backwards compatibility for the old
require()API. If we're in the browser, export as a standard global object.