Skip to content
This repository has been archived by the owner on Jun 16, 2019. It is now read-only.

Marker Clusterer icons are gone. Solved. #59

Closed
mluis opened this issue May 12, 2016 · 22 comments
Closed

Marker Clusterer icons are gone. Solved. #59

mluis opened this issue May 12, 2016 · 22 comments

Comments

@mluis
Copy link

mluis commented May 12, 2016

Marker Clusterer icons are gone because they link to the old repository.
Changing the URL to the one below solves the issue:

https://raw.githubusercontent.com/googlemaps/js-marker-clusterer/gh-pages/images/m

@diogolast
Copy link

thanks!!

@ghost
Copy link

ghost commented May 12, 2016

Two other issues already mention this (and include solutions): #55 #54

@nivas90
Copy link

nivas90 commented May 12, 2016

When can we expect to see the commit done on the main branch? This is currently breaking our application.
Thanks

@yannbug
Copy link

yannbug commented May 12, 2016

+1

@djozsef
Copy link

djozsef commented May 13, 2016

GitHub is not a CDN. You should host the image files on your own and set imagePath option.

@mluis
Copy link
Author

mluis commented May 13, 2016

@djozsef perhaps the link should be this one?

https://cdn.rawgit.com/googlemaps/js-marker-clusterer/gh-pages/images/m

@djozsef
Copy link

djozsef commented May 13, 2016

@mluis Sound like a plan! I am not sure if it is a proper canonical way but should work even in master as default imagePath.

@davidpelayo
Copy link

This unplanned change has caused bugs on thousand of applications. I consider resources shouldn't have been deleted, though.

@mluis
Copy link
Author

mluis commented May 13, 2016

That's out of my realm but I agree that this should have been a soft handover.

@davidpelayo
Copy link

davidpelayo commented May 13, 2016

@mluis we have currently thousand of sites published (of our clients) which are visually failing because of this.... I mean, I thought these things were more serious within the different google organization departments...

@ghost
Copy link

ghost commented May 13, 2016

@davidpelayo I fully understand you, but "failing" is maybe a bit much. The markerclusterer still works, it's just the images that don't show up.

@davidpelayo
Copy link

@WACMemphis I agree. It depends on what you mean by saying failing.

However, the responsibility of these actions considering how many people have been using this solution for production-apps it's high enough for double-checking beforehand.

@ghost
Copy link

ghost commented May 13, 2016

@davidpelayo Yes, I'm with you on this. I have to update quite a few applications myself.
I'm opting to use my own images from now on though.

BTW, left a comment on your commit.

@brianhogg
Copy link

I've been passing in the MAPPARAMS.imageurl var to set your local path to the images, but the markerclusterer_compiled.js script (or _packed.js in the old version) does not seem to look at this. It appears to be hard coded to the googlecode.com repo.

The attached minified version does the trick.
markerclusterer.min.js.zip

@wedneyyuri
Copy link

GitHub is not a CDN. You should host the image files on your own and set imagePath option.

In my opinion, the imagePath option should be optional but throw a warning if not passed.

@bunnyhero
Copy link

GitHub is not a CDN. You should host the image files on your own and set imagePath option.

It's broken even on the documentation site's example pages :) (e.g. https://googlemaps.github.io/js-marker-clusterer/examples/simple_example.html )

@KashifAhmed
Copy link

For time being replace MARKER_CLUSTER_IMAGE_PATH_ with
'https://raw.githubusercontent.com/googlemaps/js-marker-clusterer/gh-pages/images/m'

This trick work for me.

@philipdbrown
Copy link

When instantiating the MarkerClusterer, you can pass a new path to the image set with the imagePath option:

var mc = new MarkerClusterer(map, makers, {imagePath: 'https://www.mydomain.com/m'});

that is also a quick fix. Although you can still change the js-marker-cluster, but I like to keep that clean. Just my thoughts.

@PeterTheOne
Copy link
Contributor

fixed by 2f659a3

@sudheerec107
Copy link

Suppose if i have many clusters in my map and i want clusters with different color depending on some value. How to achieve this.

@cmcintosh
Copy link

cmcintosh commented Nov 29, 2016 via email

@sebastiangug
Copy link

All of the links in this thread are 404 now.

Thanks google.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests