-
Notifications
You must be signed in to change notification settings - Fork 768
Marker Clusterer icons are gone. Solved. #59
Comments
thanks!! |
When can we expect to see the commit done on the main branch? This is currently breaking our application. |
+1 |
GitHub is not a CDN. You should host the image files on your own and set imagePath option. |
@djozsef perhaps the link should be this one? https://cdn.rawgit.com/googlemaps/js-marker-clusterer/gh-pages/images/m |
@mluis Sound like a plan! I am not sure if it is a proper canonical way but should work even in master as default |
This unplanned change has caused bugs on thousand of applications. I consider resources shouldn't have been deleted, though. |
That's out of my realm but I agree that this should have been a soft handover. |
@mluis we have currently thousand of sites published (of our clients) which are visually failing because of this.... I mean, I thought these things were more serious within the different google organization departments... |
@davidpelayo I fully understand you, but "failing" is maybe a bit much. The markerclusterer still works, it's just the images that don't show up. |
@WACMemphis I agree. It depends on what you mean by saying failing. However, the responsibility of these actions considering how many people have been using this solution for production-apps it's high enough for double-checking beforehand. |
@davidpelayo Yes, I'm with you on this. I have to update quite a few applications myself. BTW, left a comment on your commit. |
I've been passing in the MAPPARAMS.imageurl var to set your local path to the images, but the markerclusterer_compiled.js script (or _packed.js in the old version) does not seem to look at this. It appears to be hard coded to the googlecode.com repo. The attached minified version does the trick. |
In my opinion, the |
It's broken even on the documentation site's example pages :) (e.g. https://googlemaps.github.io/js-marker-clusterer/examples/simple_example.html ) |
For time being replace MARKER_CLUSTER_IMAGE_PATH_ with This trick work for me. |
When instantiating the MarkerClusterer, you can pass a new path to the image set with the imagePath option:
that is also a quick fix. Although you can still change the js-marker-cluster, but I like to keep that clean. Just my thoughts. |
fixed by 2f659a3 |
Suppose if i have many clusters in my map and i want clusters with different color depending on some value. How to achieve this. |
You probably could extend the class for this, im not sure what you would
use to decide which cluster gets which icon, but should be a simple
addition of a if check.
…On 11/29/16 2:03 PM, sudheerkb wrote:
Suppose if i have many clusters in my map and i want clusters with
different color depending on some value. How to achieve this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACA0jR4Hyro4Xp7ZKQoYS_zP-jGkdDR9ks5rC8AugaJpZM4IdBxo>.
|
All of the links in this thread are 404 now. Thanks google. |
Marker Clusterer icons are gone because they link to the old repository.
Changing the URL to the one below solves the issue:
https://raw.githubusercontent.com/googlemaps/js-marker-clusterer/gh-pages/images/m
The text was updated successfully, but these errors were encountered: