fix line numbers on IE. On IE String.match returns a different value …

…for unmatched groups and IE uses margin-left to indent lists.
googlearchive · Jul 21, 2010 · ed2bf56 · ed2bf56
1 parent 01b3777
commit ed2bf56
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/prettify.css b/src/prettify.css
@@ -14,7 +14,7 @@
 pre.prettyprint { padding: 2px; border: 1px solid #888; display: list }
 
 /* Specify class=linenums on a pre to get line numbering */
-ol.linenums { margin: 0 }
+ol.linenums { margin-top: 0; margin-bottom: 0 } /* IE indents via margin-left */
 li.L0,
 li.L1,
 li.L2,

diff --git a/src/prettify.js b/src/prettify.js
@@ -1113,7 +1113,8 @@ window['_pr_isIE6'] = function () {
       for (var i = 0; i < 10; ++i) {
         lineBreaks[i] = lineBreakHtml + '</li><li class="L' + i + '">';
       }
-      var lineNum = numberLines[1] - 1 || 0;  // Lines are 1-indexed
+      var lineNum = numberLines[1] && numberLines[1].length 
+          ? numberLines[1] - 1 : 0;  // Lines are 1-indexed
       html.push('<ol class="linenums"><li class="L', (lineNum) % 10, '"');
       if (lineNum) {
         html.push(' value="', lineNum + 1, '"');