Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly underscore elixir directory names with digits in the middle #908

Merged
merged 2 commits into from
Jan 19, 2021
Merged

fix: Properly underscore elixir directory names with digits in the middle #908

merged 2 commits into from
Jan 19, 2021

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Jan 15, 2021

This is affecting the area120tables client, which Elixir is generating into the directory area120_tables but synthtool is trying to write the metadata file into area120tables, resulting in a synth failure (googleapis/elixir-google-api#6707)

@dazuma dazuma requested a review from chingor13 January 15, 2021 23:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2021
@dazuma dazuma merged commit b259489 into googleapis:master Jan 19, 2021
@dazuma dazuma deleted the pr/elixir-underscore branch January 21, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SurferJeffAtGoogle SurferJeffAtGoogle SurferJeffAtGoogle approved these changes

@chingor13 chingor13 Awaiting requested review from chingor13 chingor13 is a code owner

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dazuma @SurferJeffAtGoogle