chore(java): allow overriding the versioning section of the Java README #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
frankyn
reviewed
Apr 16, 2020
| @@ -135,13 +135,15 @@ Java 7 or above is required for using this client. | |||
|
|
|||
| ## Versioning | |||
|
|
|||
| {% if 'partials' in metadata and metadata['partials']['versioning'] -%} | |||
| {{ metadata['partials']['versioning'] }} | |||
| {% else %} | |||
There was a problem hiding this comment.
How does GA get represented in this README?
There was a problem hiding this comment.
Ah, nevermind, missed the badge at the top. LGTM.
frankyn
approved these changes
Apr 16, 2020
| @@ -135,13 +135,15 @@ Java 7 or above is required for using this client. | |||
|
|
|||
| ## Versioning | |||
|
|
|||
| {% if 'partials' in metadata and metadata['partials']['versioning'] -%} | |||
| {{ metadata['partials']['versioning'] }} | |||
| {% else %} | |||
There was a problem hiding this comment.
Ah, nevermind, missed the badge at the top. LGTM.
SurferJeffAtGoogle
approved these changes
Apr 17, 2020
chingor13
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting a
versioningsection in.readme-partials.yamlto override the versioning section.