Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automatic kokoro label in and /gcbrun comment #1965

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented May 15, 2024

From reading the configuration (https://github.com/googleapis/repo-automation-bots/pull/1682/files), it accepts multiple objects.

@blakeli0
Copy link
Contributor

Do we expect this change to be propagated to all libraries through Owlbot PRs?

@suztomo
Copy link
Member Author

suztomo commented May 15, 2024

Do we expect this change to be propagated to all libraries through Owlbot PRs?

Yes.

@blakeli0
Copy link
Contributor

Do we expect this change to be propagated to all libraries through Owlbot PRs?

Yes.

Thanks! I don't see this file trusted-contribution.yml in google-cloud-java, is it excluded in some steps?

@suztomo
Copy link
Member Author

suztomo commented Jun 3, 2024

I don't see this file trusted-contribution.yml in google-cloud-java, is it excluded in some steps?

There's no OwlBot configuration for google-cloud-java any more https://github.com/googleapis/google-cloud-java/tree/main/.github. Thus the postprocessor does not run.

@suztomo suztomo enabled auto-merge (squash) June 3, 2024 14:47
@suztomo
Copy link
Member Author

suztomo commented Jun 3, 2024

Experiment succeeded in googleapis/java-bigtable#2233 (comment)

@blakeli0
Copy link
Contributor

blakeli0 commented Jun 3, 2024

I don't see this file trusted-contribution.yml in google-cloud-java, is it excluded in some steps?

There's no OwlBot configuration for google-cloud-java any more https://github.com/googleapis/google-cloud-java/tree/main/.github. Thus the postprocessor does not run.

We only recently removed the OwlBot configuration, but this file was introduced years ago, so this file should at least exist in google-cloud-java. Just like in java-bigtable, this file exists but a few new configs are added by this change.

@suztomo
Copy link
Member Author

suztomo commented Jun 5, 2024

The file was not there before the monorepo migraiton https://github.com/googleapis/google-cloud-java/tree/main_202208/.github.

so this file should at least exist in google-cloud-java

What observations made you think that?

@suztomo
Copy link
Member Author

suztomo commented Jun 5, 2024

The postprocessor had been running, but owlbot-java has special treatment not to process the root directory of google-cloud-java.

Copy link
Contributor

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @diegomarquezp We need to add these templates to hermetic build as well.

@suztomo suztomo merged commit bd2bae8 into master Jun 5, 2024
11 checks passed
@suztomo suztomo deleted the suztomo-patch-2 branch June 5, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants