-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: automatic kokoro label in and /gcbrun comment #1965
Conversation
Do we expect this change to be propagated to all libraries through Owlbot PRs? |
Yes. |
Thanks! I don't see this file |
There's no OwlBot configuration for google-cloud-java any more https://github.com/googleapis/google-cloud-java/tree/main/.github. Thus the postprocessor does not run. |
Experiment succeeded in googleapis/java-bigtable#2233 (comment) |
We only recently removed the OwlBot configuration, but this file was introduced years ago, so this file should at least exist in google-cloud-java. Just like in java-bigtable, this file exists but a few new configs are added by this change. |
The file was not there before the monorepo migraiton https://github.com/googleapis/google-cloud-java/tree/main_202208/.github.
What observations made you think that? |
The postprocessor had been running, but owlbot-java has special treatment not to process the root directory of google-cloud-java. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @diegomarquezp We need to add these templates to hermetic build as well.
From reading the configuration (https://github.com/googleapis/repo-automation-bots/pull/1682/files), it accepts multiple objects.