chore: update java template license header year #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomarquezp
requested review from
chingor13,
bcoe and
a team
as code owners
suztomo
approved these changes
Jan 18, 2024
suztomo
changed the title
suztomo
changed the title
blakeli0
reviewed
Jan 18, 2024
| @@ -29,7 +29,7 @@ | |||
| JAR_DOWNLOAD_URL = "https://github.com/google/google-java-format/releases/download/google-java-format-{version}/google-java-format-{version}-all-deps.jar" | |||
| DEFAULT_FORMAT_VERSION = "1.7" | |||
| GOOD_LICENSE = """/* | |||
| * Copyright 2023 Google LLC | |||
There was a problem hiding this comment.
Can we make it a variable so it automatically updates to current year? The tests would automatically start failing in a new year, but I think it could be a better way to force us update the copyright in time. WDYT @suztomo ?
There was a problem hiding this comment.
I added a variable to compute the license year.
blakeli0
approved these changes
Jan 19, 2024
bcoe
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.