Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regenerate pb2 files with grpcio-tools==1.48.2 #1834

Merged
merged 2 commits into from
Jul 21, 2023
Merged

fix: regenerate pb2 files with grpcio-tools==1.48.2 #1834

merged 2 commits into from
Jul 21, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 21, 2023 •
edited
Loading

I ran the following commands to regenerate pb2 files in this repository with the protoc in grpcio-tools==1.48.2 which is compatible with both protobuf 3.x and 4.x

pip install grpcio-tools==1.48.2
python3 -m grpc_tools.protoc /usr/local/google/home/partheniou/git/synthtool/synthtool/protos/metadata.proto --proto_path=/usr/local/google/home/partheniou/git/synthtool/synthtool/protos --python_out=.
python3 -m grpc_tools.protoc /usr/local/google/home/partheniou/git/synthtool/synthtool/protos/preconfig.proto --proto_path=/usr/local/google/home/partheniou/git/synthtool/synthtool/protos --python_out=.

This addresses the issue in #1829 (comment)

chalmerlowe
chalmerlowe approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

NOTE there is some form of linting error that caused the kokoro presubmit to fail.

@parthea parthea enabled auto-merge (squash) July 21, 2023 16:03
@parthea parthea merged commit d69f4e8 into master Jul 21, 2023
@parthea parthea deleted the regenerate-pb2 branch July 21, 2023 16:08
holtskinner pushed a commit to holtskinner/synthtool that referenced this pull request Aug 1, 2023
@parthea @holtskinner
fix: regenerate pb2 files with grpcio-tools==1.48.2 (googleapis#1834)
5d7942d 
* fix: regenerate pb2 files with grpcio-tools==1.48.2

* run black on pb2 files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@SurferJeffAtGoogle SurferJeffAtGoogle Awaiting requested review from SurferJeffAtGoogle

@chingor13 chingor13 Awaiting requested review from chingor13 chingor13 is a code owner

@bcoe bcoe Awaiting requested review from bcoe

Assignees

@chingor13 chingor13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthea @chalmerlowe @chingor13