fix(php): handle missing directories gracefully #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
requested review from
SurferJeffAtGoogle,
chingor13,
bcoe and
a team
as code owners
2 tasks
SurferJeffAtGoogle
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a bigger change than it is. I just wrapped the "copy gapics" and "copy protos" sections in a conditional to see if those expected directories exist. Without this, synthtool throws an exception (a
FileNotFoundError: [Errno 2] No such file or directoryerror) whensrcorproto/srcdoesn't exist.Additionally, I added a log message if the required
version_stringdoesn't exist, as this covers an edge case with proto-only copies (since theversion_stringis derived from the gapic path).This is important for using OwlBot to generate our "Cloud Common Protos", which won't contain a GAPIC service, but for which we'd still like to use OwlBot (see googleapis/google-cloud-php#5935).