Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade google-java-format to 1.13.0 #1288

Merged
merged 4 commits into from
Nov 29, 2021
Merged

deps: upgrade google-java-format to 1.13.0 #1288

merged 4 commits into from
Nov 29, 2021

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Nov 23, 2021 •
edited
Loading

Fixes #1287

googleapis/java-shared-config#361 sets the google-java-format version 1.13.0. Timur already committed the Java version upgrade for the linter. 42a3786

As per @chingor13 , the formatter version was previously pinned to the old formatter because of Java 7 support.

@suztomo suztomo requested a review from a team as a code owner November 23, 2021 19:02
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2021
@suztomo
deps: upgrade google-java-format to 1.11.0
8aab0b8 
Fixes #1287

google-java-format 1.11.0 is the version used by fmt-maven-plugin 2.12
(latest as of November 2021).
@suztomo suztomo requested a review from chingor13 November 23, 2021 19:05
@suztomo
Copy link
Member Author

suztomo commented Nov 23, 2021

The minimum supported runtime version is now JDK 11.

https://github.com/google/google-java-format/releases/tag/google-java-format-1.8

@suztomo
Copy link
Member Author

suztomo commented Nov 23, 2021

Why did it fail?

@chanseokoh chanseokoh changed the title deps: upgrade google-java-format to 1.11.0 deps: upgrade google-java-format to 1.13.0 Nov 23, 2021
@suztomo
Copy link
Member Author

suztomo commented Nov 23, 2021

@chingor13 Would you mind taking over this? I don't have visibility into the failing build log and not familiar with the release process of Owlbot.

@chanseokoh
Copy link
Contributor

I don't have access to the build log either, but try updating this test data.

@suztomo suztomo mentioned this pull request Nov 23, 2021
Closed
4 tasks
@suztomo
Copy link
Member Author

suztomo commented Nov 23, 2021

@chanseokoh Great. Now it passed owlbot-java-presubmit check. Thank you.

@suztomo
Copy link
Member Author

suztomo commented Nov 23, 2021

All checks have passed.

@suztomo suztomo mentioned this pull request Nov 24, 2021
Closed
@lesv lesv merged commit fdf20ea into master Nov 29, 2021
@lesv lesv deleted the suztomo-patch-1 branch November 29, 2021 17:53
@Neenu1995
Copy link
Contributor

This PR is causing owlbot post processor to thrash and fail owlbot check in java client libraries.
The java_format_version need to be updaed in languages/java.py file in synthtool too. This will break existing synthtool libraries. So, this PR is being reverted until all libraries are migrated to owlbot.

Neenu1995 added a commit that referenced this pull request Nov 29, 2021
@Neenu1995
Revert "deps: upgrade google-java-format to 1.13.0 (#1288)"
8b4bd8e 
This reverts commit fdf20ea.
@Neenu1995 Neenu1995 mentioned this pull request Nov 29, 2021
Merged
lesv pushed a commit that referenced this pull request Nov 29, 2021
@Neenu1995
Revert "deps: upgrade google-java-format to 1.13.0 (#1288)" (#1292)
5f60f93 
This reverts commit fdf20ea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanseokoh chanseokoh chanseokoh left review comments

@lesv lesv lesv approved these changes

@chingor13 chingor13 Awaiting requested review from chingor13

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Owlbot should use a newer version of google-java-format
4 participants
@suztomo @chanseokoh @Neenu1995 @lesv