Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix log.py from failing lint-3.6 check #1191

Merged
merged 1 commit into from
Aug 24, 2021
Merged

chore: fix log.py from failing lint-3.6 check #1191

merged 1 commit into from
Aug 24, 2021

Conversation

Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Aug 24, 2021

lint-3.6 check was failing in master branch of synthtool with the following error.

synthtool/log.py:21: error: Cannot assign to a type
synthtool/log.py:21: error: Incompatible types in assignment (expression has type "None", variable has type "Type[ColoredFormatter]")
synthtool/log.py:71: error: Incompatible types in assignment (expression has type "Formatter", variable has type "ColoredFormatter")
Found 3 errors in 1 file (checked 47 source files)
nox > Command mypy synthtool autosynth failed with exit code 1
nox > Session lint-3.6 failed.

@Neenu1995 Neenu1995 requested a review from a team August 24, 2021 16:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
@Neenu1995 Neenu1995 requested a review from parthea August 24, 2021 17:02
@chingor13 chingor13 merged commit 430b9d6 into master Aug 24, 2021
@chingor13 chingor13 deleted the fix-log branch August 24, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants