chore(python): refactor unit / system test dependency install #1186
Conversation
google-cla
bot
added
the
cla: yes
| session.install("-e", *UNIT_TEST_LOCAL_DEPENDENCIES, *constraints) | ||
|
|
||
| if UNIT_TEST_DEPENDENCIES: | ||
| session.install("-e", *UNIT_TEST_DEPENDENCIES, *constraints) |
There was a problem hiding this comment.
These aren't supposed to be installed in "editable" mode, are they?
There was a problem hiding this comment.
Likely not -- I doubt anybody is using a git: URL for a dependency.
| @@ -81,29 +126,38 @@ def lint_setup_py(session): | |||
| session.run("python", "setup.py", "check", "--restructuredtext", "--strict") | |||
|
|
|||
|
|
|||
| def install_unittest_dependencies(session, *constraints): | |||
| session.install(*UNIT_TEST_STANDARD_DEPENDENCIES, *constraints) | |||
There was a problem hiding this comment.
I'd prefer if we installed UNIT_TEST_STANDARD_DEPENDENCIES and UNIT_TEST_DEPENDENCIES all in one go.
There was a problem hiding this comment.
Hmm, I'm not sure I see why? The prior template alwasy installed the "standard" deps ("mock", "asyncmock", "pytest", "pytest-cov", "pytest-asyncio") in a separate step, prior to any others.
There was a problem hiding this comment.
The reason is that the pip resolver can run in one go. Otherwise subsequent pip installs might have to downgrade some packages.
| "pytest-cov", | ||
| "pytest-asyncio", | ||
| ] | ||
| UNIT_TEST_EXTERNAL_DEPENDENCIES = [{% for v in unit_test_external_dependencies %} |
There was a problem hiding this comment.
Do we want to deprecate unit_test_external_dependencies? It seems quire redundant to me with unit_test_dependencies
|
PR made from a now-removed fork. Replaced by #1294. |
Closes #1185.
Opened PR as a draft for discussion.