Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): remove python 3.7 from kokoro Dockerfile #1155

Merged
merged 4 commits into from
Jul 14, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 14, 2021

A lot of python repositories have a failing Kokoro docs-presubmit check with error gpg: keyserver receive failed: No name. For example, googleapis/python-asset#227

The issue is that the fetch_gpg_keys.sh script is failing in the Docker file here because the key here is no longer available on the keyserver.

This PR removes fetch_gpg_keys.sh as, in most repositories, we don't need to install additional python versions. We can use the default python version in the ubuntu 20.04 base image which is python 3.8.10.

@parthea parthea requested a review from a team as a code owner July 14, 2021 11:23
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2021
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! And just in the right time, I just notice the failing docs-presubmit tests myself, too.

@parthea parthea changed the title build: remove python 3.7 from kokoro Dockerfile build(python): remove python 3.7 from kokoro Dockerfile Jul 14, 2021
@parthea parthea requested a review from a team July 14, 2021 11:31
@parthea parthea requested a review from busunkim96 July 14, 2021 11:38
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Jul 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit e44dc0c into master Jul 14, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-docs-presubmit branch July 14, 2021 16:08
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants