Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add constraints file check for python samples #1012

Merged
merged 8 commits into from
Apr 10, 2021

Conversation

leahecole
Copy link
Contributor

@leahecole leahecole commented Mar 31, 2021

This is the sibling PR to GoogleCloudPlatform/python-docs-samples#5611
and this is the issue opened for it GoogleCloudPlatform/python-docs-samples#5549

If you look at the files in this example repo, you'll see that renovate successfully opened a PR on three constraints files in samples directories and subdirectories, and properly ignored constraints files at the root level

cc @tswast

TODO:

  • update renovate to check for samples/constraints.txt dependency updates
  • run lint locally to double check that I'm not introducing lint error

@leahecole leahecole requested a review from a team as a code owner March 31, 2021 18:40
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 31, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2021
@leahecole leahecole marked this pull request as draft March 31, 2021 21:35
@leahecole
Copy link
Contributor Author

I converted this to a draft because we're talking in the samples owners group about if I also need to add an update to the renovate template, and if so, what that will look like. I'll make it ready to review once that's been decided.

@leahecole leahecole marked this pull request as ready for review April 2, 2021 23:27
@parthea parthea assigned leahecole and unassigned parthea Apr 8, 2021
@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Apr 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0a071b3 into master Apr 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the python_constraints_file branch April 10, 2021 05:50
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 10, 2021
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants