-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add constraints file check for python samples #1012
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
Issues that are directly related to samples.
label
Mar 31, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Mar 31, 2021
Merged
8 tasks
I converted this to a draft because we're talking in the samples owners group about if I also need to add an update to the renovate template, and if so, what that will look like. I'll make it ready to review once that's been decided. |
busunkim96
approved these changes
Apr 3, 2021
parthea
approved these changes
Apr 5, 2021
leahecole
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Apr 10, 2021
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Apr 10, 2021
tswast
reviewed
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the sibling PR to GoogleCloudPlatform/python-docs-samples#5611
and this is the issue opened for it GoogleCloudPlatform/python-docs-samples#5549
If you look at the files in this example repo, you'll see that renovate successfully opened a PR on three constraints files in
samples
directories and subdirectories, and properly ignoredconstraints
files at the root levelcc @tswast
TODO: