feat: Add support for additional_bindings #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR depends on the corresponding one in gax: googleapis/gax-java#1680
|
Kudos, SonarCloud Quality Gate passed! |
blakeli0
reviewed
May 17, 2022
| @@ -63,6 +65,8 @@ public int compareTo(HttpBinding o) { | |||
|
|
|||
| public abstract String pattern(); | |||
|
|
|||
| public abstract List<String> additionalPatterns(); | |||
There was a problem hiding this comment.
Do we need to use List here? Can we use Set? Does order matter? Do duplicates matter?
There was a problem hiding this comment.
I think technically duplicates are allowed even though they will be useless. Bindings come in list from proto file descriptor, so keeping them as list here.
blakeli0
reviewed
May 17, 2022
| @@ -22,7 +22,7 @@ public class PatternParser { | |||
|
|
|||
| // This method tries to parse all named segments from pattern and sort in natual order | |||
| // e.g. /v1beta1/{table_name=tests/*}/{routing_id=instances/*}/** -> (routing_id, table_name) | |||
| public static Set<String> getPattenBindings(String pattern) { | |||
There was a problem hiding this comment.
Good catch! Thanks for correcting my mistake!
There was a problem hiding this comment.
Oh, I actually thought it was my typo, only now realized that it was the class you created =).
blakeli0
approved these changes
May 17, 2022
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
This PR depends on the corresponding one in gax: googleapis/gax-java#1680
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on the corresponding one in gax: googleapis/gax-java#1680