chore: set up fully working Maven pom.xml #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's incredible is that the Maven unit tests on CI took ~45 seconds even though nothing was cached for the first time. (OTOH, Bazel currently takes ~10 minutes for unit tests.) |
Codecov Report
@@ Coverage Diff @@
## main #937 +/- ##
==========================================
+ Coverage 87.96% 91.13% +3.17%
==========================================
Files 156 265 +109
Lines 16198 27632 +11434
Branches 1179 1203 +24
==========================================
+ Hits 14248 25182 +10934
- Misses 1608 2096 +488
- Partials 342 354 +12
Continue to review full report at Codecov.
|
meltsufin
approved these changes
Feb 18, 2022
blakeli0
reviewed
Feb 18, 2022
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
* chore: set up fully working pom.xml * chore: update DEVELOPMENT.md
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [googleapis-common-protos](https://togithub.com/googleapis/python-api-common-protos) | `==1.56.3` -> `==1.56.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMSIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4xIn0=-->
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
](https://renovatebot.com){kind=link}
🤖 I have created a release *beep* *boop* --- ## [2.8.17](googleapis/java-core@v2.8.16...v2.8.17) (2022-09-28) ### Dependencies * Update dependency cachetools to v5 ([#943](googleapis/java-core#943)) ([1406c09](googleapis/java-core@1406c09)) * Update dependency certifi to v2022.9.24 ([#934](googleapis/java-core#934)) ([b6e1904](googleapis/java-core@b6e1904)) * Update dependency charset-normalizer to v2.1.1 ([#938](googleapis/java-core#938)) ([ac43d61](googleapis/java-core@ac43d61)) * Update dependency click to v8.1.3 ([#946](googleapis/java-core#946)) ([05fe31f](googleapis/java-core@05fe31f)) * Update dependency com.google.api.grpc:proto-google-common-protos to v2.9.4 ([#945](googleapis/java-core#945)) ([3ebff6f](googleapis/java-core@3ebff6f)) * Update dependency gcp-releasetool to v1.8.8 ([#935](googleapis/java-core#935)) ([0f99ae1](googleapis/java-core@0f99ae1)) * Update dependency google-api-core to v2.10.1 ([#947](googleapis/java-core#947)) ([dedddfe](googleapis/java-core@dedddfe)) * Update dependency google-auth to v2.12.0 ([#948](googleapis/java-core#948)) ([67e53aa](googleapis/java-core@67e53aa)) * Update dependency google-cloud-core to v2.3.2 ([#936](googleapis/java-core#936)) ([a0d2e3e](googleapis/java-core@a0d2e3e)) * Update dependency google-cloud-storage to v2.5.0 ([#949](googleapis/java-core#949)) ([6edc6e3](googleapis/java-core@6edc6e3)) * Update dependency google-crc32c to v1.5.0 ([#950](googleapis/java-core#950)) ([0dda0a2](googleapis/java-core@0dda0a2)) * Update dependency googleapis-common-protos to v1.56.4 ([#937](googleapis/java-core#937)) ([b22a2b1](googleapis/java-core@b22a2b1)) * Update dependency importlib-metadata to v4.12.0 ([#951](googleapis/java-core#951)) ([6abe579](googleapis/java-core@6abe579)) * Update dependency jeepney to v0.8.0 ([#952](googleapis/java-core#952)) ([6a392e8](googleapis/java-core@6a392e8)) * Update dependency jinja2 to v3.1.2 ([#953](googleapis/java-core#953)) ([18a54a7](googleapis/java-core@18a54a7)) * Update dependency keyring to v23.9.3 ([#954](googleapis/java-core#954)) ([5ceabaa](googleapis/java-core@5ceabaa)) * Update dependency markupsafe to v2.1.1 ([#955](googleapis/java-core#955)) ([f64e9bf](googleapis/java-core@f64e9bf)) * Update dependency protobuf to v3.20.2 ([#956](googleapis/java-core#956)) ([fb1aea6](googleapis/java-core@fb1aea6)) * Update dependency protobuf to v4 ([#944](googleapis/java-core#944)) ([6b02535](googleapis/java-core@6b02535)) * Update dependency pyjwt to v2.5.0 ([#939](googleapis/java-core#939)) ([cc8ba46](googleapis/java-core@cc8ba46)) * Update dependency requests to v2.28.1 ([#940](googleapis/java-core#940)) ([ec195e3](googleapis/java-core@ec195e3)) * Update dependency typing-extensions to v4.3.0 ([#941](googleapis/java-core#941)) ([4c414e9](googleapis/java-core@4c414e9)) * Update dependency zipp to v3.8.1 ([#942](googleapis/java-core#942)) ([6dfb0d8](googleapis/java-core@6dfb0d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #936. Please review that first.Adds a fully working
pom.xmlthat compiles the generator and runs JUnit tests. Typemvn verify, and everything will just work.What is nice is that it uses the shared-dependencies BOM. Formatting works too via Maven.
The PR also sets up Maven CI.
Doesn't touch Bazel, so there's no side-effect to the current state.