[ggj][codegen] fix: Use service name in ServiceClient codegen comments #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miraleung
requested review from
summer-ji-eng and
xiaozhenliu-gg5
as code owners
google-cla
bot
added
the
cla: yes
xiaozhenliu-gg5
approved these changes
Oct 28, 2020
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
…urcemanager to v3-rev20220828-2.0.0 (#417) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.apis:google-api-services-cloudresourcemanager](http://nexus.sonatype.org/oss-repository-hosting.html) ([source](http://svn.sonatype.org/spice/tags/oss-parent-7)) | `v3-rev20220807-2.0.0` -> `v3-rev20220828-2.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xODQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE4NC4yIn0=-->
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
Source-Link: googleapis/synthtool@f58d313 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `1.95.4` -> `1.96.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [com.google.cloud:google-cloud-core-bom](https://togithub.com/googleapis/java-core) | `1.95.4` -> `1.96.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/java-shared-dependencies/compare/1.4.0...v2.0.0) (2021-08-03) ### ⚠ BREAKING CHANGES * promote to 2.0.0 (#428) ### Features * promote to 2.0.0 ([#428](https://www.github.com/googleapis/java-shared-dependencies/issues/428)) ([0047ac7](https://www.github.com/googleapis/java-shared-dependencies/commit/0047ac79b44f970d0b8208d572eff82994ea6fce)) ### Documentation * we don't use this as a parent pom ([#407](https://www.github.com/googleapis/java-shared-dependencies/issues/407)) ([e3da184](https://www.github.com/googleapis/java-shared-dependencies/commit/e3da18442f7094d965d5bba207e5e429b9d7fed2)) ### Dependencies * update dependency com.fasterxml.jackson:jackson-bom to v2.12.4 ([#398](https://www.github.com/googleapis/java-shared-dependencies/issues/398)) ([702f57b](https://www.github.com/googleapis/java-shared-dependencies/commit/702f57bfbfe9a76ffae78486500c29b74cb5b63d)) * update dependency com.google.api:api-common to v1.10.6 ([#411](https://www.github.com/googleapis/java-shared-dependencies/issues/411)) ([44c5d4e](https://www.github.com/googleapis/java-shared-dependencies/commit/44c5d4e2b5a96c2b0986c441b0d6b995bc6ef3e2)) * update dependency com.google.api:api-common to v2 ([#414](https://www.github.com/googleapis/java-shared-dependencies/issues/414)) ([823ee33](https://www.github.com/googleapis/java-shared-dependencies/commit/823ee33390d8180f0d4304af80ccc811afec25d9)) * update dependency com.google.auth:google-auth-library-bom to v0.27.0 ([#400](https://www.github.com/googleapis/java-shared-dependencies/issues/400)) ([10f94b5](https://www.github.com/googleapis/java-shared-dependencies/commit/10f94b5ce9ffdb31051b63279bcb07281f5713a3)) * update dependency com.google.auth:google-auth-library-bom to v1 ([#413](https://www.github.com/googleapis/java-shared-dependencies/issues/413)) ([f624156](https://www.github.com/googleapis/java-shared-dependencies/commit/f6241568157cf5cffef090bfa10fc90727b50f68)) * update dependency com.google.cloud:grpc-gcp to v1.1.0 ([#403](https://www.github.com/googleapis/java-shared-dependencies/issues/403)) ([0a44b8e](https://www.github.com/googleapis/java-shared-dependencies/commit/0a44b8e0299d92a455794bae4949e30812b7c241)) * update dependency com.google.errorprone:error_prone_annotations to v2.8.0 ([#406](https://www.github.com/googleapis/java-shared-dependencies/issues/406)) ([991d1a2](https://www.github.com/googleapis/java-shared-dependencies/commit/991d1a2b381b774d262c6cf595098e5958cf0f86)) * update dependency com.google.errorprone:error_prone_annotations to v2.8.1 ([#426](https://www.github.com/googleapis/java-shared-dependencies/issues/426)) ([f7f9a23](https://www.github.com/googleapis/java-shared-dependencies/commit/f7f9a23fdadcbd84242bb85294d192dd77233e9c)) * update gax.version to v1.67.0 ([#405](https://www.github.com/googleapis/java-shared-dependencies/issues/405)) ([a874c6f](https://www.github.com/googleapis/java-shared-dependencies/commit/a874c6f95c98c72e881da433140633f8568e7da3)) * update gax.version to v2 (major) ([#418](https://www.github.com/googleapis/java-shared-dependencies/issues/418)) ([f08bbca](https://www.github.com/googleapis/java-shared-dependencies/commit/f08bbca7313e29ad43209ca4f3748f7ebe1ccff1)) * update google.core.version to v1.96.1 ([#417](https://www.github.com/googleapis/java-shared-dependencies/issues/417)) ([cbe5faf](https://www.github.com/googleapis/java-shared-dependencies/commit/cbe5fafb1343afa0c345003c12260946f08b2360)) * update google.core.version to v2 (major) ([#427](https://www.github.com/googleapis/java-shared-dependencies/issues/427)) ([1121e9c](https://www.github.com/googleapis/java-shared-dependencies/commit/1121e9ccf83b62e08372e13d4a84d0e924cabce7)) * update guava to 30.1.1-jre ([#423](https://www.github.com/googleapis/java-shared-dependencies/issues/423)) ([275543b](https://www.github.com/googleapis/java-shared-dependencies/commit/275543bc8dbef691310854e370525139672d6466)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
](https://renovatebot.com){kind=link}
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [1.94.5](https://www.github.com/googleapis/java-core/compare/v1.94.4...v1.94.5) (2021-04-08) ### Dependencies * update dependency com.google.api:gax-bom to v1.63.0 ([#415](https://www.github.com/googleapis/java-core/issues/415)) ([5767cfb](https://www.github.com/googleapis/java-core/commit/5767cfb3d5379f36cf3cdee21dc1d70b84393802)) * update dependency com.google.auth:google-auth-library-bom to v0.25.2 ([#408](https://www.github.com/googleapis/java-core/issues/408)) ([36b221f](https://www.github.com/googleapis/java-core/commit/36b221f0bc7a64aaa26d52e16034ecd81a84765f)) * update dependency com.google.errorprone:error_prone_annotations to v2.6.0 ([#412](https://www.github.com/googleapis/java-core/issues/412)) ([7d6f76d](https://www.github.com/googleapis/java-core/commit/7d6f76db81b09476da92e386581e129f4d8a800e)) * update dependency com.google.http-client:google-http-client-bom to v1.39.1 ([#407](https://www.github.com/googleapis/java-core/issues/407)) ([6dff74c](https://www.github.com/googleapis/java-core/commit/6dff74c850f2e0baeb93da7c886e185923a6db1b)) * update dependency com.google.protobuf:protobuf-bom to v3.15.6 ([#405](https://www.github.com/googleapis/java-core/issues/405)) ([6657e98](https://www.github.com/googleapis/java-core/commit/6657e98ada384e400239623f673b18fa43bccbb8)) * update dependency com.google.protobuf:protobuf-bom to v3.15.7 ([#413](https://www.github.com/googleapis/java-core/issues/413)) ([0bbca1f](https://www.github.com/googleapis/java-core/commit/0bbca1f98d5a6cb24614e5a942289ce10ab036c6)) * update dependency com.google.protobuf:protobuf-bom to v3.15.8 ([#418](https://www.github.com/googleapis/java-core/issues/418)) ([efb1d40](https://www.github.com/googleapis/java-core/commit/efb1d40aaf58217e067d4a469aa331d74614d8fd)) * update dependency io.grpc:grpc-bom to v1.36.1 ([#410](https://www.github.com/googleapis/java-core/issues/410)) ([0bbf669](https://www.github.com/googleapis/java-core/commit/0bbf669f1526fdd2068b02428a0ae8242fd08c3b)) * update dependency io.grpc:grpc-bom to v1.37.0 ([#416](https://www.github.com/googleapis/java-core/issues/416)) ([6dca414](https://www.github.com/googleapis/java-core/commit/6dca414e7c3ccfdc24c8142000f1aa9f5b9a646d)) * update guava ([#417](https://www.github.com/googleapis/java-core/issues/417)) ([291ba00](https://www.github.com/googleapis/java-core/commit/291ba00be22d6229c05ff61023628bf783f5b340)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.