[ggj][infra][5/5] support goldens updates for AST integration test #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto add_golden_files
xiaozhenliu-gg5
requested review from
miraleung and
summer-ji-eng
as code owners
google-cla
bot
added
the
cla: yes
xiaozhenliu-gg5
added
do not merge
miraleung
suggested changes
Sep 29, 2020
|
|
||
| # Run `bazel run src/test/java/com/google/api/generator/engine:JavaCodeGeneratorTest_update` | ||
| # to update goldens as expected generated code. | ||
| updated_golden( |
There was a problem hiding this comment.
Not part of this PR, but just noticed this. Can we change this (separately) to update_golden as was proposed in the original doc?
There was a problem hiding this comment.
sg, was following Vadym's suggestion to make all the name of bazel target a "noun" instead of "verb". But i'm open to change it back in a separate PR.
There was a problem hiding this comment.
fixed this in PR #357
miraleung
approved these changes
Oct 1, 2020
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find more details in design doc: go/java-micro-file-diff-infra
This PR is for moving the AST integration test to file-diff infrastructure, based one #279