-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: modify hermetic build docs #3331
Merged
+382
−263
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b5109a7
docs: modify hermetic build docs
JoeWang1127 52386c7
change comments in cli
JoeWang1127 0a3641a
add instructions on how to generate release note
JoeWang1127 425ba11
restore param
JoeWang1127 55c2b40
add notes in docker run
JoeWang1127 7524b65
rephase
JoeWang1127 64dc16b
rephase
JoeWang1127 19ebfb2
move build image steps to development guide
JoeWang1127 acf40ff
change title
JoeWang1127 eba3cb7
change shell type
JoeWang1127 44b4baf
Merge branch 'main' into docs/modify-hermetic-build-docs
JoeWang1127 dee681d
simplify docker run
JoeWang1127 a68ef4d
rephase
JoeWang1127 244f82a
remove generator env in docker run
JoeWang1127 d31dc36
add an advanced example of docker run
JoeWang1127 a7b585f
add a note
JoeWang1127 df96948
restore
JoeWang1127 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
restore param
commit 425ba11faefb8af2a7034d0b5048cf9cebf6920d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the right spelling but it's what's defined in the repo-level section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should be
googleapis_committish
according to #3208 (comment).However, I think the refactor should be in its own PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I misspelled the suggestion string. I was trying to point out that we should stick to
googleapis_commitish
(onet
) since we haven't done such refactor.