Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add codeowners and repo settings #312

Merged
merged 4 commits into from
Sep 23, 2020
Merged

chore: add codeowners and repo settings #312

merged 4 commits into from
Sep 23, 2020

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2020
miraleung
miraleung suggested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@miraleung miraleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the owners settings narrower for this repo? Since it's in development, let's start with myself, and we can add to that set as more folks become familiar with this codebase.

@JustinBeckwith
Copy link
Contributor Author

Sure thing! For which part?

  • For CODEOWNERS right now, actools or yoshi-java can sign off - do you want that to just be you?
  • For write/admin access, it's set up kind of standard java. Do you want to change that bit?

@summer-ji-eng
Copy link
Contributor

Sure thing! For which part?

  • For CODEOWNERS right now, actools or yoshi-java can sign off - do you want that to just be you?
  • For write/admin access, it's set up kind of standard java. Do you want to change that bit?

Currently, @miraleung, @summer-ji-eng @xiaozhenliu-gg5 are the main contributors to this repo.

@JustinBeckwith
Copy link
Contributor Author

I just yanked any team config to reduce confusion. Feel free to update if/when you like!

summer-ji-eng
summer-ji-eng reviewed Sep 19, 2020
View reviewed changes
.github/CODEOWNERS Outdated
# For syntax help see:
# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax

* @miraleung, @summer-ji-eng @xiaozhenliu-gg5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need comma here.

@summer-ji-eng
Copy link
Contributor

Thanks @JustinBeckwith helping us on this. LGTM, wait for @miraleung take another look.

@JustinBeckwith
Copy link
Contributor Author

Thanks! Ready for another look @miraleung :)

@JustinBeckwith JustinBeckwith merged commit b6c136c into master Sep 23, 2020
@JustinBeckwith JustinBeckwith deleted the syncy branch September 23, 2020 04:14
suztomo pushed a commit that referenced this pull request Dec 16, 2022
@release-please
chore(main): release 2.7.3 (#312)
a7d31ca 
🤖 I have created a release *beep* *boop*
---


### [2.7.3](googleapis/java-common-protos@v2.7.2...v2.7.3) (2022-02-08)


### Dependencies

* update dependency com.google.protobuf:protobuf-bom to v3.19.4 ([#309](googleapis/java-common-protos#309)) ([2456122](googleapis/java-common-protos@2456122))
* update dependency com.google.protobuf:protobuf-java to v3.19.4 ([#308](googleapis/java-common-protos#308)) ([a0ed177](googleapis/java-common-protos@a0ed177))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Dec 16, 2022
@release-please
chore(main): release 1.2.11-SNAPSHOT (#312)
f713999 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@yoshi-automation
chore(java): detect sample-secrets in build.sh (#312)
744262f 
Fixes #904

Source-Author: Neenu Shaji <[email protected]>
Source-Date: Wed Mar 24 15:50:02 2021 -0400
Source-Repo: googleapis/synthtool
Source-Sha: bb854b6c048619e3be4e8b8ce8ed10aa74ea78ef
Source-Link: googleapis/synthtool@bb854b6
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@renovate-bot @stephaniewang526
deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1…
e416c1c 
….0.2 (#312)

* deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1.0.2

* bump google.common-protos.version to 2.0.0

Co-authored-by: Stephanie Wang <[email protected]>
suztomo pushed a commit that referenced this pull request Mar 21, 2023
@release-please
chore: release 1.93.10 (#301)
6eecfdb 
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.93.10](https://www.github.com/googleapis/java-core/compare/v1.93.9...v1.93.10) (2020-10-30)


### Dependencies

* update core dependencies ([#294](https://www.github.com/googleapis/java-core/issues/294)) ([5f6b784](https://www.github.com/googleapis/java-core/commit/5f6b784ad94b71553d339e3450b17f70dd307e6d))
* update core transport dependencies ([#295](https://www.github.com/googleapis/java-core/issues/295)) ([39fdd06](https://www.github.com/googleapis/java-core/commit/39fdd06a84a92c2d314c9de8b1baba0cd5b6589d))
* update dependency com.google.api:api-common to v1.10.1 ([#302](https://www.github.com/googleapis/java-core/issues/302)) ([6ebd6b1](https://www.github.com/googleapis/java-core/commit/6ebd6b186dc99bc0a306e2b28150d84c6e6d8125))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.0.2 ([#312](https://www.github.com/googleapis/java-core/issues/312)) ([e416c1c](https://www.github.com/googleapis/java-core/commit/e416c1cafdafac7165f986194a028096ff936993))
* update dependency com.google.guava:guava-bom to v30 ([#310](https://www.github.com/googleapis/java-core/issues/310)) ([1026809](https://www.github.com/googleapis/java-core/commit/1026809177b3460a7170e13cb205b8505bde1ddb))
* update dependency io.grpc:grpc-bom to v1.33.0 ([#309](https://www.github.com/googleapis/java-core/issues/309)) ([e021cb0](https://www.github.com/googleapis/java-core/commit/e021cb0943b7b538df79941f98c46cbc53633959))
* update dependency org.threeten:threetenbp to v1.4.5 ([#297](https://www.github.com/googleapis/java-core/issues/297)) ([9286f76](https://www.github.com/googleapis/java-core/commit/9286f761449ae51bd7ae4fe84494f9b987a45623))
* update dependency org.threeten:threetenbp to v1.5.0 ([#314](https://www.github.com/googleapis/java-core/issues/314)) ([35bcf4d](https://www.github.com/googleapis/java-core/commit/35bcf4d3ff1f47295a466ff37685b7b526af2b1a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@summer-ji-eng summer-ji-eng summer-ji-eng left review comments

@miraleung miraleung miraleung requested changes

@chingor13 chingor13 Awaiting requested review from chingor13

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinBeckwith @summer-ji-eng @miraleung