-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ggj][infra][2/5] feat: integrate java-diff-util library with dummy test #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…va into java_diff_util
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 10, 2020
summer-ji-eng
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
miraleung
suggested changes
Sep 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits addressed.
src/test/java/com/google/api/generator/gapic/dummy/FileDiffInfraDummyTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/api/generator/test/framework/Differ.java
Outdated
Show resolved
Hide resolved
miraleung
approved these changes
Sep 15, 2020
src/test/java/com/google/api/generator/gapic/dummy/FileDiffInfraDummyTest.java
Outdated
Show resolved
Hide resolved
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-protobuf](https://togithub.com/grpc/grpc-java) | `1.44.0` -> `1.44.1` | [![age](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.44.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.44.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.44.1/compatibility-slim/1.44.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.grpc:grpc-protobuf/1.44.1/confidence-slim/1.44.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.44.1`](https://togithub.com/grpc/grpc-java/releases/v1.44.1) ##### **Bug Fixes** - xds: fix the validation code to accept new-style CertificateProviderPluginInstance wherever used ([#​8901](https://togithub.com/grpc/grpc-java/issues/8901) fixes [#​8885](https://togithub.com/grpc/grpc-java/issues/8885)) - binder: Fix a ServiceConnection leak ([#​8861](https://togithub.com/grpc/grpc-java/issues/8861) closes [#​8726](https://togithub.com/grpc/grpc-java/issues/8726)) - android: fix for app coming to foreground ([#​8904](https://togithub.com/grpc/grpc-java/issues/8904) closes [#​8850](https://togithub.com/grpc/grpc-java/issues/8850)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
🤖 I have created a release *beep* *boop* --- ### [1.2.6](googleapis/java-iam@v1.2.5...v1.2.6) (2022-03-01) ### Dependencies * update dependency io.grpc:grpc-protobuf to v1.44.1 ([#290](googleapis/java-iam#290)) ([c7713a0](googleapis/java-iam@c7713a0)) * update dependency io.grpc:grpc-stub to v1.44.1 ([#291](googleapis/java-iam#291)) ([c0cb638](googleapis/java-iam@c0cb638)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find more details in design doc: go/java-micro-file-diff-infra
Removed part of the expected code, and the test failure looks as below:
The following step would be: