-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ggj][codegen] feat: add comments for GrpcServiceCallableFactory, GrpcServiceStub, ServiceStub #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods to ServiceStubSettings
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 3, 2020
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.7.1](https://www.github.com/googleapis/java-common-protos/compare/v2.7.0...v2.7.1) (2022-01-05) ### Bug Fixes * **java:** add -ntp flag to native image testing command ([#1299](https://www.github.com/googleapis/java-common-protos/issues/1299)) ([#272](https://www.github.com/googleapis/java-common-protos/issues/272)) ([7f0784e](https://www.github.com/googleapis/java-common-protos/commit/7f0784eda9292fb8d7d89ccc10e65abfb0adeb24)) * **java:** run Maven in plain console-friendly mode ([#1301](https://www.github.com/googleapis/java-common-protos/issues/1301)) ([#283](https://www.github.com/googleapis/java-common-protos/issues/283)) ([e8581a4](https://www.github.com/googleapis/java-common-protos/commit/e8581a455a70e6b4fd666536efd85e290ad40370)) ### Dependencies * update dependency com.google.protobuf:protobuf-bom to v3.19.2 ([#285](https://www.github.com/googleapis/java-common-protos/issues/285)) ([6e4ee04](https://www.github.com/googleapis/java-common-protos/commit/6e4ee040712b6733bf46dfa1cb2115d7fd24c1b4)) * update dependency com.google.protobuf:protobuf-java to v3.19.2 ([#286](https://www.github.com/googleapis/java-common-protos/issues/286)) ([e2f7272](https://www.github.com/googleapis/java-common-protos/commit/e2f72726c6ffa88d8bec024d1e330e110469094c)) * update dependency io.grpc:grpc-bom to v1.43.1 ([#276](https://www.github.com/googleapis/java-common-protos/issues/276)) ([1d64bc1](https://www.github.com/googleapis/java-common-protos/commit/1d64bc12929fba276dea742d1b908377dfa4097d)) * update dependency io.grpc:grpc-protobuf to v1.43.1 ([#277](https://www.github.com/googleapis/java-common-protos/issues/277)) ([fe70634](https://www.github.com/googleapis/java-common-protos/commit/fe70634a4b7041eb2d6370f8a8e123006f605d5e)) * update dependency io.grpc:grpc-stub to v1.43.1 ([#278](https://www.github.com/googleapis/java-common-protos/issues/278)) ([9ffc759](https://www.github.com/googleapis/java-common-protos/commit/9ffc759dab14601b9271d9c04525d67cb51c4901)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
…-info-reports-plugin to v3.2.1 (#276)
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
This PR updates the GitHub Actions configuration for Linkage Monitor. Before this change, the CI configuration has "mvn install" command with 6 options. It turned out that a slight difference in the command line option from "build.sh" fails the build in google-auth-library-java repository (GoogleCloudPlatform/cloud-opensource-java#1941). (@Neenu1995 found the build failure. Thanks!) Therefore, this change updates the configuration so that Linkage Monitor job just uses "build.sh" to install the artifacts into local Maven repository. # How did I test? I tested this change in java-spanner repository with this draft PR: googleapis/java-spanner#868 <img width="889" alt="Screen Shot 2021-02-12 at 16 54 18" src="https://user-images.githubusercontent.com/28604/107826467-f3cd5c80-6d52-11eb-86f1-1a8053326978.png"> It succeeded. Source-Author: Tomo Suzuki <[email protected]> Source-Date: Tue Feb 16 15:56:09 2021 -0500 Source-Repo: googleapis/synthtool Source-Sha: f327d3b657a63ae4a8efd7f011a15eacae36b59c Source-Link: googleapis/synthtool@f327d3b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.