chore: Update ci.yaml to setup Java 21 CI tests #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
|
build (21) failed at Integration tests step in commit 7a314dc . |
product-auto-label
bot
added
size: xs
|
After enabling the tests verbosity, I find that the tests have actually failed (not a timeout or too big size failure). |
|
reproduced the error locally, this is the test.log output for one of the tests - Looks like (Google's) com.google.testing.junit.runner.junit4.JUnit4Runner does not seem to work in Java 21. |
ddixit14
changed the title
product-auto-label
bot
added
size: s
|
Got the error - Possible root cause - Gradle 8 introduced the archiveClassifier property as a replacement for classifier. It serves the same purpose of customizing the name and location of the JAR file. Looks like we need to modify our jar generation tasks configuration to use archiveClassifier instead of classifier. |
blakeli0
reviewed
Dec 18, 2023
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.3-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip | |||
There was a problem hiding this comment.
Is this because Gradle 8.4 is the minimum version that supports Java 21?
There was a problem hiding this comment.
suztomo
reviewed
Dec 18, 2023
.github/workflows/ci.yaml
Outdated
| @@ -28,7 +28,7 @@ jobs: | |||
| mvn install -B -ntp -DskipTests -Dclirr.skip -Dcheckstyle.skip | |||
| - name: Integration Tests | |||
| run: | | |||
| bazelisk --batch test //test/integration/... | |||
| bazelisk --batch test //test/integration/... --test_verbose_timeout_warnings | |||
There was a problem hiding this comment.
Do you still need this? If yes, would you add source code comment about the significance for Java 21?
There was a problem hiding this comment.
I don't think we need this. removed it.
suztomo
reviewed
Dec 18, 2023
.github/workflows/ci.yaml
Outdated
| @@ -28,7 +28,7 @@ jobs: | |||
| mvn install -B -ntp -DskipTests -Dclirr.skip -Dcheckstyle.skip | |||
| - name: Integration Tests | |||
| run: | | |||
| bazelisk --batch test //test/integration/... | |||
| bazelisk --batch test //test/integration/... | |||
There was a problem hiding this comment.
Remove unnecessary space ad the end. Same for Line 126.
There was a problem hiding this comment.
git diff origin/main is your friend.
|
suztomo
approved these changes
Dec 20, 2023
|
In the release note of next release of this repository, would you (manually) add a comment about the Gradle version change? |
blakeli0
reviewed
Dec 20, 2023
| @@ -17,12 +17,12 @@ dependencies { | |||
| } | |||
|
|
|||
| task javadocJar(type: Jar) { | |||
| classifier = 'javadoc' | |||
| archiveClassifier = 'javadoc' | |||
There was a problem hiding this comment.
What's the minimum Gradle version that supports archiveClassifier? This file is used by self-service client libraries, if a customer is using an very old version of Gradle, I guess it would not work anymore for them?
There was a problem hiding this comment.
Tried 8.1 but didn't work. As suggested, I have separated out build (21) job and excluded the self service clients steps in it. Does that work?
suztomo
reviewed
Dec 26, 2023
| @@ -48,7 +48,28 @@ jobs: | |||
| pushd /tmp/java-compute/google-cloud-compute-small-v1-java | |||
| ./gradlew clean build publishToMavenLocal sourcesJar allJars | |||
| popd | |||
|
|
|||
| build-java-21: | |||
| name: "build(21) except self-service clients" | |||
There was a problem hiding this comment.
Would you add source code comment why build (21) is special?
|
|
|
blakeli0
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to setup Java 21 build for the repository.