Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add HttpJson CRUD Showcase tests #1589

Merged
merged 16 commits into from
Apr 12, 2023
Merged

chore: Add HttpJson CRUD Showcase tests #1589

merged 16 commits into from
Apr 12, 2023

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Mar 30, 2023

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Part of #1439 ☕️

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 30, 2023
@lqiu96 lqiu96 changed the title Main showcase crud chore: Add HttpJson CRUD Showcase tests Mar 30, 2023
@lqiu96 lqiu96 mentioned this pull request Mar 30, 2023
Closed
27 tasks
@lqiu96
Copy link
Contributor Author

lqiu96 commented Mar 30, 2023 •
edited
Loading

Failure is resolved with this fix: googleapis/gapic-showcase#1263 -- Released in Showcase v0.26.1.

Will create a separate PR to upgrade to the latest showcase version to unblock this PR.

@lqiu96 lqiu96 marked this pull request as ready for review April 5, 2023 17:11
@lqiu96 lqiu96 requested a review from a team as a code owner April 5, 2023 17:11
@lqiu96
Copy link
Contributor Author

lqiu96 commented Apr 10, 2023

@burkedavison @mpeddada1 @blakeli0 Would you all be able to re-review this PR?

@lqiu96
Copy link
Contributor Author

lqiu96 commented Apr 11, 2023

Thanks all. Will merge tomorrow if unless there are any more concerns.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 11, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lqiu96 lqiu96 merged commit 59efbbb into main Apr 12, 2023
@lqiu96 lqiu96 deleted the main-showcase_crud branch April 12, 2023 14:00
blakeli0
blakeli0 reviewed Apr 12, 2023
View reviewed changes
showcase/gapic-showcase/pom.xml
@@ -107,7 +107,7 @@
<artifactId>fmt-maven-plugin</artifactId>
<version>2.9</version>
<configuration>
<filesNamePattern>(IT.*\.java)|(.*Test.java)</filesNamePattern>
<filesNamePattern>(IT.*\.java)|(.*Test.java)|(TestClientInitializer.java)</filesNamePattern>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we are explicitly specifying the files in the fmt plugin, because we want to exclude some files? @mpeddada1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeddada1 mpeddada1 mpeddada1 approved these changes

@blakeli0 blakeli0 blakeli0 left review comments

@burkedavison burkedavison burkedavison approved these changes

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lqiu96 @blakeli0 @burkedavison @mpeddada1