Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add aggregate test coverage collection of gax within the showcase and gax modules #1430

Merged
merged 22 commits into from
Mar 16, 2023
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add enableTestCoverage parameter and fix showcase compilation
  • Loading branch information
mpeddada1 committed Mar 16, 2023
commit 31365de113bcd388f850a9a29d917c61dc0419c0
3 changes: 1 addition & 2 deletions .github/workflows/ci-maven.yaml
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ jobs:
- name: Unit Tests
run: |
mvn test --batch-mode --no-transfer-progress -Dcheckstyle.skip \
suztomo marked this conversation as resolved.
Show resolved Hide resolved
-Dfmt.skip
-Dfmt.skip -DenableTestCoverage
- run: bazelisk version
- name: Install maven modules
run: |
@@ -74,7 +74,6 @@ jobs:
set -x
export JAVA_HOME=$JAVA11_HOME
export PATH=${JAVA_HOME}/bin:$PATH

# Why not compile? It's because the process needs to package jar so
# that gapic-generator-java module can use testlib modules of gax.
mvn verify --batch-mode --no-transfer-progress -Dcheckstyle.skip \
3 changes: 3 additions & 0 deletions showcase/gapic-showcase/pom.xml
Original file line number Diff line number Diff line change
@@ -171,18 +171,21 @@
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax</artifactId>
<type>test-jar</type>
<classifier>testlib</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax-grpc</artifactId>
<type>test-jar</type>
<classifier>testlib</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax-httpjson</artifactId>
<type>test-jar</type>
<classifier>testlib</classifier>
<scope>test</scope>
</dependency>