Skip to content

Commit

Permalink
chore: downstream check for all libraries in single job (#322)
Browse files Browse the repository at this point in the history
* [DO_NOT_MERGE]chore: downstream check for all libraries in single job

* chore: move to java-core directory

* chore: fix api-common version

* chore: change publish command

* chore: make java version 11

* chore: make java version 8

* chore: clone core with https

* chore: test more libraries

* chore: check all libraries

* chore: check all libraries

* chore: trigger job with label

* chore: trigger on pull request with label

* chore: trigger on pull request target with label

* chore: run on pull-request

* chore: run on pull-request labeled

* chore: run on pull-request labeled

* chore: only run on pull request label

* chore: generalize script

* chore: add correct parameters

* chore:  minor fixes

* chore: add retry

* fix typo

* remove timeout

* Update downstream.yaml

* chore: fix typo

* chore: debug

* chore: debug 2

* chore: debug 3

* chore: try cloning in separate directories

* chore: fix folder path

* chore: remove retry

* chore: try all librraies

* chore: fix maven build command

* Update downstream-client-library-check.sh

* Update downstream-client-library-check.sh

* Update downstream.yaml

* Update downstream-client-library-check.sh
  • Loading branch information
Neenu1995 authored Feb 11, 2022
1 parent 441c1b4 commit d53cb53
Show file tree
Hide file tree
Showing 2 changed files with 234 additions and 0 deletions.
142 changes: 142 additions & 0 deletions api-common-java/.github/workflows/downstream.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,142 @@
on:
pull_request:
types: [ labeled ]
branches:
- main
name: downstream
jobs:
dependencies:
if: ${{ github.event.label.name == 'downstream-check:run' }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
java: [8]
repo:
# This list needs to be updated manually until an automated solution is in place.
- accessapproval
- accesscontextmanager
- aiplatform
- analytics-admin
- analytics-data
- api-gateway
- apigee-connect
- appengine-admin
- area120-tables
- artifact-registry
- asset
- assured-workloads
- automl
- bigquery
- bigqueryconnection
- bigquerydatatransfer
- bigquerymigration
- bigqueryreservation
- bigtable
- billing
- billingbudgets
- binary-authorization
- channel
- cloudbuild
- compute
- contact-center-insights
- container
- containeranalysis
- data-fusion
- datacatalog
- dataflow
- datalabeling
- dataproc
- dataproc-metastore
- datastore
- datastream
- debugger-client
- deploy
- dialogflow
- dialogflow-cx
- dlp
- dms
- dns
- document-ai
- domains
- errorreporting
- essential-contacts
- eventarc
- filestore
- firestore
- functions
- game-servers
- gke-connect-gateway
- gkehub
- gsuite-addons
- iam-admin
- iamcredentials
- iot
- kms
- language
- life-sciences
- logging
- logging-logback
- managed-identities
- mediatranslation
- memcache
- monitoring
- monitoring-dashboards
- network-management
- network-security
- networkconnectivity
- notebooks
- orchestration-airflow
- orgpolicy
- os-config
- os-login
- phishingprotection
- policy-troubleshooter
- private-catalog
- profiler
- pubsublite
- recaptchaenterprise
- recommendations-ai
- recommender
- redis
- resource-settings
- resourcemanager
- retail
- scheduler
- secretmanager
- security-private-ca
- securitycenter
- securitycenter-settings
- service-control
- service-management
- service-usage
- servicedirectory
- shell
- spanner
- spanner-jdbc
- speech
- storage
- storage-nio
- storage-transfer
- talent
- tasks
- texttospeech
- tpu
- trace
- translate
- video-intelligence
- video-transcoder
- vision
- vpcaccess
- webrisk
- websecurityscanner
- workflow-executions
- workflows
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v1
with:
java-version: ${{matrix.java}}
- run: java -version
- run: sudo apt-get install libxml2-utils
- run: .kokoro/downstream-client-library-check.sh api-common ${{matrix.repo}}
92 changes: 92 additions & 0 deletions api-common-java/.kokoro/downstream-client-library-check.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
#!/bin/bash
# Copyright 2020 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# Presubmit to ensure the dependencies of the Google Libraries BOM, with the modification of change
# in the PR, pick up the highest versions among transitive dependencies.
# https://maven.apache.org/enforcer/enforcer-rules/requireUpperBoundDeps.html
set -eo pipefail
# Display commands being run.
set -x

CORE_LIBRARY_ARTIFACT=$1
CLIENT_LIBRARY=$2
## Get the directory of the build script
scriptDir="$(realpath "$(dirname "${BASH_SOURCE[0]}")")"
## cd to the parent directory, i.e. the root of the git repo
cd "${scriptDir}"/..

CORE_VERSION=$( ./gradlew -q properties | grep '^version: ' | cut -d' ' -f2 )
echo "$CORE_VERSION"

# Publish api-common to local maven to make it available for downstream libraries
./gradlew publishToMavenLocal

# Round 1
# Check this java core library against HEAD of java-shared dependencies

git clone "https://github.com/googleapis/java-shared-dependencies.git" --depth=1
pushd java-shared-dependencies/first-party-dependencies

# replace version
xmllint --shell pom.xml << EOF
setns x=http://maven.apache.org/POM/4.0.0
cd .//x:artifactId[text()="${CORE_LIBRARY_ARTIFACT}"]
cd ../x:version
set ${CORE_VERSION}
save pom.xml
EOF

cd ..
mvn verify install -B -V -ntp -fae \
-DskipTests=true \
-Dmaven.javadoc.skip=true \
-Dgcloud.download.skip=true \
-Denforcer.skip=true

SHARED_DEPS_VERSION_POM=pom.xml
# Namespace (xmlns) prevents xmllint from specifying tag names in XPath
SHARED_DEPS_VERSION=$(sed -e 's/xmlns=".*"//' ${SHARED_DEPS_VERSION_POM} | xmllint --xpath '/project/version/text()' -)

if [ -z "${SHARED_DEPS_VERSION}" ]; then
echo "Version is not found in ${SHARED_DEPS_VERSION_POM}"
exit 1
fi

# Round 2
# Check this BOM against java client libraries
git clone "https://github.com/googleapis/java-${CLIENT_LIBRARY}.git" --depth=1
pushd java-"${CLIENT_LIBRARY}"

if [[ $CLIENT_LIBRARY == "bigtable" ]]; then
pushd google-cloud-bigtable-deps-bom
fi

# replace version
xmllint --shell pom.xml << EOF
setns x=http://maven.apache.org/POM/4.0.0
cd .//x:artifactId[text()="google-cloud-shared-dependencies"]
cd ../x:version
set ${SHARED_DEPS_VERSION}
save pom.xml
EOF

if [[ $CLIENT_LIBRARY == "bigtable" ]]; then
popd
fi

mvn verify install -B -V -ntp -fae \
-Dmaven.javadoc.skip=true \
-Dgcloud.download.skip=true \
-Denforcer.skip=true

0 comments on commit d53cb53

Please sign in to comment.