Skip to content

Commit

Permalink
[ggj][fix] fix: update bazel target name (#357)
Browse files Browse the repository at this point in the history
* update bazel target name

* rename

* fix
  • Loading branch information
xiaozhenliu-gg5 authored Oct 1, 2020
1 parent 069de97 commit 8b9da3e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion rules_bazel/java/java_diff_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ overwritten_golden = rule(
implementation = _overwritten_golden_impl,
)

def updated_golden(name, test_class_name, srcs):
def golden_update(name, test_class_name, srcs):
junit_output_name = "%s_output" % name
junit_output_zip(
name = junit_output_name,
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/google/api/generator/engine/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("//:rules_bazel/java/java_diff_test.bzl", "updated_golden")
load("//:rules_bazel/java/java_diff_test.bzl", "golden_update")

package(default_visibility = ["//visibility:public"])

Expand Down Expand Up @@ -32,7 +32,7 @@ TEST_CLASS_NAME = "com.google.api.generator.engine.JavaCodeGeneratorTest"

# Run `bazel run src/test/java/com/google/api/generator/engine:JavaCodeGeneratorTest_update`
# to update goldens as expected generated code.
updated_golden(
golden_update(
name = "JavaCodeGeneratorTest_update",
srcs = [
":engine_files",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("//:rules_bazel/java/java_diff_test.bzl", "updated_golden")
load("//:rules_bazel/java/java_diff_test.bzl", "golden_update")

package(default_visibility = ["//visibility:public"])

Expand Down Expand Up @@ -28,7 +28,7 @@ TEST_CLASS_NAME = "com.google.api.generator.gapic.dummy.FileDiffInfraDummyTest"

# Run `bazel run src/test/java/com/google/api/generator/gapic/dummy:FileDiffInfraDummyTest_update`
# to update goldens as expected generated code.
updated_golden(
golden_update(
name = "FileDiffInfraDummyTest_update",
srcs = [
":dummy_files",
Expand Down

0 comments on commit 8b9da3e

Please sign in to comment.