Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CODEOWNERS config #727

Merged
merged 3 commits into from
Feb 2, 2021
Merged

chore: update CODEOWNERS config #727

merged 3 commits into from
Feb 2, 2021

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@JustinBeckwith JustinBeckwith requested a review from a team as a code owner February 2, 2021 03:24
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #727 (87e59a2) into master (8dab7bf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #727   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files          55       55           
  Lines        6683     6683           
  Branches      616      616           
=======================================
  Hits         5823     5823           
  Misses        859      859           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dab7bf...2814088. Read the comment docs.

@bcoe
Copy link
Contributor

bcoe commented Feb 2, 2021

@JustinBeckwith should this include a CODEOWNERS file?

@JustinBeckwith
Copy link
Contributor Author

So ... we have a CODEOWNERS here!
https://github.com/googleapis/release-please/blob/master/.github/CODEOWNERS

I am trying to move us to a model similar to what happens in Java, where it's generated from the .repo-metadata.json:
googleapis/synthtool#936

I wanted to land the .repo-metadata.json changes first, and then let synthtool handle any cleanup along the way.

@bcoe bcoe merged commit 1414225 into master Feb 2, 2021
@bcoe bcoe deleted the ownerf1 branch February 2, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants