Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ruby-yoshi): Remove bolded scope and fix link removal #1382

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Apr 13, 2022

Two more minor adjustments to the changelog formatting for ruby-yoshi.

  • Because we have monorepos, we typically include the package name in the scope of the commit message so we can identify commits in the history more easily. But the package name isn't useful in the changelog since each package has is own changelog, so we're removing it.
  • Adjusted the regex that removes trailing links to pull requests and commits, so it will handle any number of such links in any order (the previous regex did not recognize a commit link that didn't follow a pr link) and to limit it to github links to reduce false positives.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 13, 2022
@dazuma dazuma marked this pull request as ready for review April 13, 2022 18:45
@dazuma dazuma requested a review from a team as a code owner April 13, 2022 18:45
@dazuma dazuma requested a review from a team April 13, 2022 18:45
@dazuma dazuma marked this pull request as draft April 13, 2022 18:50
@dazuma dazuma force-pushed the pr/yoshi-ruby-1 branch 3 times, most recently from 6ecc7d9 to 3ce9492 Compare April 13, 2022 22:02
@dazuma dazuma marked this pull request as ready for review April 13, 2022 23:28
fix(ruby-yoshi): Fix link removal regex to handle additional cases
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit f6b3202 into googleapis:main Apr 14, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 14, 2022
@dazuma dazuma deleted the pr/yoshi-ruby-1 branch April 14, 2022 17:39
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 14, 2022
🤖 I have created a release *beep* *boop*
---


### [13.10.2](v13.10.1...v13.10.2) (2022-04-14)


### Bug Fixes

* **java:** snapshots should bump versionsMap versions ([#1386](#1386)) ([558331c](558331c)), closes [#1381](#1381)
* **ruby-yoshi:** Remove bolded scope and fix link removal ([#1382](#1382)) ([f6b3202](f6b3202))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit to erezrokah/release-please that referenced this pull request May 6, 2022
…oogleapis#1382) (googleapis#1359)

* chore: Enable Size-Label bot in all googleapis NodeJs repositories

Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis NodeJs repositories

* Remove product

Remove product since it is by default true
Source-Link: googleapis/synthtool@f1562fa
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb4d47d0e770abad62699a4664ce6b9ff1629d50c276a6c75860a6a1853dd19b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants