Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replease PR are not creating #736

Closed
venkateshthalanki opened this issue Mar 15, 2023 · 7 comments
Closed

replease PR are not creating #736

venkateshthalanki opened this issue Mar 15, 2023 · 7 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release.

Comments

@venkateshthalanki
Copy link

TL;DR

When developer updates his branch with master. Github is giving standard commit message(Merge branch 'master' into bug-141639-featurebranch)

Action is not able to parse the message and PR is not getting created.

Expected behavior

No response

Observed behavior

No response

Action YAML

steps:
      - name: Create Release 🚀
        uses: google-github-actions/release-please-action@v3
        id: release
        with:

Log output

commit could not be parsed: f9a54b467c8267e456dcd46a651c66cb217ca0fd Merge pull request #193 from philips-internal/bug-141639-edit-session-revoke-when-call-end
❯ commit could not be parsed: 4fb31fb112f33d87bd4d309e1cba5263da8cde40 Merge branch 'master' into bug-141639-edit-session-revoke-when-call-end

Additional information

No response

@SurferJeffAtGoogle SurferJeffAtGoogle added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Mar 15, 2023
@Tragio
Copy link

Tragio commented Mar 22, 2023

I'm also having this error. I'm pushing to master and I want it to create a PR against the release branch.

I already did several commits fix: something, fix!: something and chore: something, and no PR was created.

on:
  push:
    branches:
      - master

permissions:
  contents: write
  pull-requests: write

name: release-please

jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - uses: google-github-actions/release-please-action@v3
        with:
          release-type: node
          package-name: app
          default-branch: release
✔ Building candidate release pull request for path: .
❯ type: node
❯ targetBranch: release
❯ commit could not be parsed: 29faba68b8adbb96035a0b80fa68c9fe5384f18a Merge pull request #380 from Tragio/master
⚠ No latest release pull request found.
❯ commits: 0
✔ Considering: 0 commits
✔ No commits for path: ., skipping

@venkateshthalanki
Copy link
Author

Team, any update on this bug

@csellis
Copy link

csellis commented Mar 28, 2023

Experiencing this one as well with PR to main.

name: Release

on:
  pull_request:
    branches: [main]
  push:
    branches: [main]
  workflow_dispatch:

env:
  PUBLIC_NODE_ENV: 'ci'
  # The following are required for semantic-release to build. They are not used for production.
  DATABASE_URL: ${{ secrets.PLAYWRIGHT_TEST_DB_STAGING }}
  PRIVATE_FACEBOOK_CAPI_TOKEN: ''

permissions:
  contents: write
  pull-requests: write

jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - uses: google-github-actions/release-please-action@v3
        id: release-please
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          release-type: node
          package-name: release-please-action
✔ Building pull requests
✔ Building strategies by path
❯ .: node
✔ Collecting release commit SHAs
❯ release search depth: 400
❯ Fetching releases with cursor undefined
❯ Found release for path ., v1.0.0
❯ release for path: ., version: 1.0.0, sha: 1f5f1696b21a4bc627a3409defef923c76c090fa
✔ Collecting commits since all latest releases
❯ commit search depth: 500
❯ Set(1) { '1f5f1696b21a4bc627a3409defef923c76c090fa' }
❯ Fetching merge commits on branch main with cursor: undefined
❯ Backfilling file list for commit: 669a5f9688a9f54692c7b3c1a4739[81](https://github.com/xtendops-developers/apply-sveltekit/actions/runs/4532101626/jobs/7983063931#step:2:82)72292dee1
❯ Found 0 files
❯ Backfilling file list for commit: ed3b044b1e0102fe09ecb852dc0022da17a6d4f7
❯ Found 2 files
✔ Splitting 1 commits by path
✔ Building candidate release pull request for path: .
❯ type: node
❯ targetBranch: main
❯ commit could not be parsed: 0672429572b3e8f5adcb7b7bb[83](https://github.com/xtendops-developers/apply-sveltekit/actions/runs/4532101626/jobs/7983063931#step:2:84)9e375487d0b03 Cu [86](https://github.com/xtendops-developers/apply-sveltekit/actions/runs/4532101626/jobs/7983063931#step:2:87)77gztw7 prevent retaking assessments daniel espinosa (#311)
❯ commits: 0
✔ Considering: 0 commits
✔ No commits for path: ., skipping

@Darren-Vine
Copy link

Darren-Vine commented Mar 28, 2023

We are also facing the same issue the last few days. The difference for us is the same error, 'commit could not be parsed' has started appearing at the end.

We are using a PAT token not the GH but either makes no difference.

Also tried on another internal repo we have. The first time it worked, merged the pr. Subsequent times do not trigger new PR's.

@Tragio
Copy link

Tragio commented Mar 28, 2023

This seems also related to #698.

@SurferJeffAtGoogle @chingor13 could you share something with us? 🤔

@chingor13
Copy link
Contributor

Commit could not be parsed means the commit message you are making does not match the https://conventionalcommits.org specification. When you merge a PR, you should make sure the commits that make it to your branch are curated to follow the spec (i.e. using a basic "Merge" is discouraged in favor of "Squash and merge" or "Rebase and merge").

Additionally, the Commit could not be parsed is a warning, not an error. The offending commit message is just ignored.

@venkateshthalanki
Copy link
Author

@chingor13 Agreed. Commit could not be parsed is a warning but it is not looping through other messages which are as per conventional commit. Finally apart of culprit commit message other valid commits also ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Development

No branches or pull requests

6 participants