Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR is not getting created #698

Closed
dionysuzx opened this issue Jan 19, 2023 · 2 comments
Closed

Release PR is not getting created #698

dionysuzx opened this issue Jan 19, 2023 · 2 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@dionysuzx
Copy link

dionysuzx commented Jan 19, 2023

TL;DR

The release PR is not being created after one commit has been merged (after the latest release PR was merged). I am seeing ✔ No user facing commits found since 27691e6713810d2fc3923fd1704116c11dffed05 - skipping

Expected behavior

No response

Observed behavior

No response

Action YAML

on:
  push:
    branches:
      - main
name: release-please
jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - uses: google-github-actions/release-please-action@v3
        with:
          command: manifest

Log output

✔ Building candidate release pull request for path: packages/website
❯ type: node
❯ targetBranch: main
❯ commits: 1
✔ Considering: 1 commits
❯ component: website
❯ pull request title pattern: undefined
✔ No user facing commits found since 27691e6713810d2fc3923fd1704116c11dffed05 - skipping

Additional information

the failing action is here (the repo is open source): https://github.com/taikoxyz/taiko-mono/actions/runs/3955630714/jobs/6774080262

@dionysuzx dionysuzx added the bug label Jan 19, 2023
@dionysuzx
Copy link
Author

this could be related to https://github.com/google-github-actions/release-please-action/issues/506, but I'm not sure. thank you.

@tmatsuo tmatsuo added type: question Request for information or clarification. Not an issue. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed bug labels Jan 19, 2023
@chingor13
Copy link
Contributor

In this case the commit message was for docs(website): reorganize to diataxis framework and start whitepaper... which is not a commit that triggers a new version (fix or feat). release-please is running in this repo: taikoxyz/taiko-mono#13345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

3 participants